Skip site navigation (1)Skip section navigation (2)
Date:      Sat, 6 Oct 2012 15:25:03 -0700
From:      Jason Helfman <jgh@FreeBSD.org>
To:        Doug Barton <dougb@freebsd.org>
Cc:        svn-ports-head@freebsd.org, svn-ports-all@freebsd.org, nemysis@gmx.ch, ports-committers@freebsd.org
Subject:   Re: svn commit: r305338 - in head/games/pycadia: . files
Message-ID:  <CAMuy=%2BiTW7AgjW1QGjS9n9E5hXfwLwq=kKxmBSia2nDKs_-9-g@mail.gmail.com>
In-Reply-To: <5070A09B.1090404@FreeBSD.org>
References:  <201210060537.q965bUpk005984@svn.freebsd.org> <5070A09B.1090404@FreeBSD.org>

next in thread | previous in thread | raw e-mail | index | archive | help
On Sat, Oct 6, 2012 at 2:20 PM, Doug Barton <dougb@freebsd.org> wrote:

> On 10/05/2012 22:37, Jason Helfman wrote:
> > Added: head/games/pycadia/files/pycadia.sh.in
> >
> ==============================================================================
> > --- /dev/null 00:00:00 1970   (empty, because file is newly added)
> > +++ head/games/pycadia/files/pycadia.sh.in    Sat Oct  6 05:37:29 2012
>        (r305338)
> > @@ -0,0 +1,6 @@
> > +#!/bin/sh
> > +#
> > +# $FreeBSD$
> > +
> > +cd "%%DATADIR%%"
> > +./pycadia.py
>
> Unless there is some reason to cd into that directory, you'd be better
> off with just: %%DATADIR%%/pycadia.py
>
> And in any case, shouldn't you be using exec here?
>

I can check with the maintainer, but it does need to be run from the
DATADIR specifically.
What would exec provide that isn't currently fulfilled?

Thanks

-jgh



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAMuy=%2BiTW7AgjW1QGjS9n9E5hXfwLwq=kKxmBSia2nDKs_-9-g>