From owner-cvs-all@FreeBSD.ORG Fri Mar 18 06:20:07 2005 Return-Path: Delivered-To: cvs-all@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id BB9E216A4CE; Fri, 18 Mar 2005 06:20:07 +0000 (GMT) Received: from pooker.samsco.org (pooker.samsco.org [168.103.85.57]) by mx1.FreeBSD.org (Postfix) with ESMTP id 3E7AC43D53; Fri, 18 Mar 2005 06:20:07 +0000 (GMT) (envelope-from scottl@samsco.org) Received: from [192.168.254.11] (junior-wifi.samsco.home [192.168.254.11]) (authenticated bits=0) by pooker.samsco.org (8.13.1/8.13.1) with ESMTP id j2I6Jhn3036219; Thu, 17 Mar 2005 23:19:43 -0700 (MST) (envelope-from scottl@samsco.org) Message-ID: <423A7277.1000202@samsco.org> Date: Thu, 17 Mar 2005 23:17:27 -0700 From: Scott Long User-Agent: Mozilla/5.0 (X11; U; FreeBSD i386; en-US; rv:1.7.5) Gecko/20050218 X-Accept-Language: en-us, en MIME-Version: 1.0 To: David Schultz References: <200503172221.j2HMLkfq017761@repoman.freebsd.org> <20050318055212.GA70385@FreeBSD.org> <20050318061647.GA40922@VARK.MIT.EDU> In-Reply-To: <20050318061647.GA40922@VARK.MIT.EDU> Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-2.8 required=3.8 tests=ALL_TRUSTED autolearn=failed version=3.0.2 X-Spam-Checker-Version: SpamAssassin 3.0.2 (2004-11-16) on pooker.samsco.org cc: cvs-src@FreeBSD.org cc: Alexey Dokuchaev cc: src-committers@FreeBSD.org cc: cvs-all@FreeBSD.org Subject: Re: cvs commit: src/lib/msun/i387 fenv.c fenv.h X-BeenThere: cvs-all@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the entire tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 18 Mar 2005 06:20:07 -0000 David Schultz wrote: > On Fri, Mar 18, 2005, Alexey Dokuchaev wrote: > >>On Thu, Mar 17, 2005 at 10:21:46PM +0000, David Schultz wrote: >> >>>das 2005-03-17 22:21:46 UTC >>> >>> FreeBSD src repository >>> >>> Modified files: >>> lib/msun/i387 fenv.c fenv.h >>> Log: >>> Make the fenv.h routines work for programs that use SSE for >>> floating-point arithmetic on i386. Now I'm going to make excuses >>> for why this code is kinda scary: >>> >>> - To avoid breaking the ABI with 5.3-RELEASE, we can't change >>> sizeof(fenv_t). I stuck the saved mxcsr in some discontiguous >>> reserved bits in the existing structure. >> >>Why do you care about ABI compatibility between 6-CURRENT and 5.3-RELEASE? >>If you plan to MFC this code at some point, you could use your current >>approach in RELENG_5. This would, of course, mean you'd have to maintain >>two different code sets, but still. > > > The reasons are manifold. For one, I would like the complicated > version to get exposure in -CURRENT before I MFC it. Further, > this only adds a few extra instructions, so it's not a big deal, > particularly compared to the code to support older processors. > You're right that I could just bump the libm version number and > break the ABI, but that inconveniences people, so I would like to > avoid it when possible. You had better bump the version number for libm before 6.0 rolls around!! I've just found a 3rd party binary-only package that supports 'FreeBSD 5.x' but is linked against libm.so.2. Ugh. We need to bury that mistake and NOT make it again. Scott