From owner-freebsd-hackers@FreeBSD.ORG Fri Jun 11 14:07:34 2004 Return-Path: Delivered-To: freebsd-hackers@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 99F2416A4CE for ; Fri, 11 Jun 2004 14:07:34 +0000 (GMT) Received: from bremen.shuttle.de (bremen.shuttle.de [194.95.249.251]) by mx1.FreeBSD.org (Postfix) with ESMTP id 40EAE43D5A for ; Fri, 11 Jun 2004 14:07:34 +0000 (GMT) (envelope-from schweikh@schweikhardt.net) Received: by bremen.shuttle.de (Postfix, from userid 10) id DCC4D3BB8A; Fri, 11 Jun 2004 16:07:23 +0200 (CEST) Received: from hal9000.schweikhardt.net (localhost [127.0.0.1]) i5BE7eIr003714; Fri, 11 Jun 2004 16:07:40 +0200 (CEST) (envelope-from schweikh@hal9000.schweikhardt.net) Received: (from schweikh@localhost)i5BE7eFF003713; Fri, 11 Jun 2004 16:07:40 +0200 (CEST) (envelope-from schweikh) Date: Fri, 11 Jun 2004 16:07:40 +0200 From: Jens Schweikhardt To: Chip Norkus Message-ID: <20040611140740.GA3355@schweikhardt.net> References: <20040611025307.GG17367@teleri.net> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20040611025307.GG17367@teleri.net> User-Agent: Mutt/1.5.6i cc: hackers@freebsd.org Subject: Re: indent bugfix / added features X-BeenThere: freebsd-hackers@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: Technical Discussions relating to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 11 Jun 2004 14:07:34 -0000 On Thu, Jun 10, 2004 at 09:53:07PM -0500, Chip Norkus wrote: # # Hi all, # # I've been working on a major project, and decided to use indent to # normalize the code a bit. In doing so I discovered a few deficencies in # the stock FreeBSD (5.2-CURRENT) indent and decided to fix them, I # thought these might be fairly common wishes (and one of them is a # bugfix) and have attached a patch which does the following: # * Adds an option to control tab use in output code (-ut and -nut) # (This is in the GNU indent) # * Adds an option to control brace placement after function declaration # (-fbs and -nfbs). What this does, specifically, is allow you to have # indent produce 'func(args..) {' instead of 'func(args..)\n{'. The old # behavior is the default. # * Fixes the indent bug when aligning variable names with an indentation # level that is not a multiple of 8. This works for both the 'tab use' # and 'no tab use' varieties of code output. # # I don't know if anyone would be interested in committing the bugfix (I # believe it is correct) or added features, but I hope someone else finds # this useful. # # -chip I'm willing to commit this if you could demonstrate that it will not produce different output in the default case than it does now. Say, run the old an new versions against the FreeBSD src tree and make a diff which should vanish apart from the bug-fixing effects. If you want to make yourself known as a quality software engineer, do the same for various sets of indent options :-) Regards, Jens -- Jens Schweikhardt http://www.schweikhardt.net/ SIGSIG -- signature too long (core dumped)