Skip site navigation (1)Skip section navigation (2)
Date:      Mon, 16 Sep 1996 22:27:28 -0700 (PDT)
From:      asami@freebsd.org (Satoshi Asami)
To:        erich@lodgenet.com
Cc:        gwh@spiders.com, ports@freebsd.org
Subject:   Re: scotty and tkined ports?
Message-ID:  <199609170527.WAA01225@silvia.HIP.Berkeley.EDU>
In-Reply-To: <199609161310.IAA22395@jake.lodgenet.com> (erich@lodgenet.com)

next in thread | previous in thread | raw e-mail | index | archive | help
 * I just upgraded scotty to 2.1.3, with the included tkined.
 * Satoshi, could you give it the once-over before I commit.
 * It should use /usr/lib/tcl, etc..

Ok....

 * The patch is relative to the port, it doesn't belong in
 * `patches/'

I can tell. :)

 * +#PREFIX=/src/scotty

What's this?

 *  HAS_CONFIGURE=  yes
 *  GNU_CONFIGURE=  yes
 * -CONFIGURE_ARGS= --with-x --prefix=${PREFIX}
 * +CONFIGURE_ARGS= --with-tcl-config=/usr/libdata/tcl 
 * --with-tk-config=/usr/local/lib --prefix=${PREFIX}

If you have GNU_CONFIGURE, you don't need HAS_CONFIGURE and --prefix.
These should be

GNU_CONFIGURE=	yes
CONFIGURE_ARGS=	--with-tcl-config=/usr/libdata/tcl \
	--with-tk-config=${PREFIX}/lib

 * +WRKSRC=${WRKDIR}/scotty-2.1.3/unix

I prefer

WRKSRC=	${WRKDIR}/${DISTNAME}/unix

(one less thing to change for an upgrade).

Satoshi

P.S. I didn't test it, I assume you have already done that.... :)



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?199609170527.WAA01225>