Skip site navigation (1)Skip section navigation (2)
Date:      Fri, 18 Oct 2002 12:32:15 -0700 (PDT)
From:      Robert Watson <rwatson@FreeBSD.org>
To:        Perforce Change Reviews <perforce@freebsd.org>
Subject:   PERFORCE change 19572 for review
Message-ID:  <200210181932.g9IJWFaq074360@repoman.freebsd.org>

next in thread | raw e-mail | index | archive | help
http://perforce.freebsd.org/chv.cgi?CH=19572

Change 19572 by rwatson@rwatson_tislabs on 2002/10/18 12:31:12

	Release vnode locks on from directory, vnode even if there is
	a MAC failure, preventing vnode lock leakage.

Affected files ...

.. //depot/projects/trustedbsd/mac/sys/kern/vfs_syscalls.c#92 edit

Differences ...

==== //depot/projects/trustedbsd/mac/sys/kern/vfs_syscalls.c#92 (text+ko) ====

@@ -2761,13 +2761,13 @@
 #ifdef MAC
 	error = mac_check_vnode_rename_from(td->td_ucred, fromnd.ni_dvp, fvp,
 	    &fromnd.ni_cnd);
+	NDFREE(&fromnd, NDF_ONLY_UNLOCK);
 	if (error) {
 		NDFREE(&fromnd, NDF_ONLY_PNBUF);
 		vrele(fromnd.ni_dvp);
 		vrele(fvp);
 		goto out1;
 	}
-	NDFREE(&fromnd, NDF_ONLY_UNLOCK);
 #endif
 	if ((error = vn_start_write(fvp, &mp, V_WAIT | PCATCH)) != 0) {
 		NDFREE(&fromnd, NDF_ONLY_PNBUF);

To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe p4-projects" in the body of the message




Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200210181932.g9IJWFaq074360>