Skip site navigation (1)Skip section navigation (2)
Date:      Sun, 15 Dec 2019 01:57:37 +0000
From:      bugzilla-noreply@freebsd.org
To:        ports-bugs@FreeBSD.org
Subject:   [Bug 242619] Mk/bsd.port.mk: Messaging around ALLOW_UNSUPPORTED_SYSTEM is confusing
Message-ID:  <bug-242619-7788-PrrPiZFYZq@https.bugs.freebsd.org/bugzilla/>
In-Reply-To: <bug-242619-7788@https.bugs.freebsd.org/bugzilla/>
References:  <bug-242619-7788@https.bugs.freebsd.org/bugzilla/>

next in thread | previous in thread | raw e-mail | index | archive | help
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D242619

Kubilay Kocak <koobs@FreeBSD.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|Works As Intended           |---
             Status|Closed                      |Open
            Summary|freebsd 11.3-p5: Ports      |Mk/bsd.port.mk: Messaging
                   |Collection support for your |around
                   |FreeBSD version has ended   |ALLOW_UNSUPPORTED_SYSTEM is
                   |                            |confusing
           Keywords|                            |needs-qa

--- Comment #9 from Kubilay Kocak <koobs@FreeBSD.org> ---
(In reply to Chris Hutchinson from comment #8)

I can't *unequivocally* speak to the original intention, but looking at the
relevant block in Mk/bsd.port.mk:

- There are two 'variations' of the message depending on whether
ALLOW_UNSUPPORTED_SYSTEM is defined or not, and=20

- *both* conditions include the same message as their first section,=20

- with the latter (when not defined) additionally including the "... if you
silence this message by defining ALLOW_UNSUPPORTED_SYSTEM"

To me, that indicates that defining ALLOW_UNSUPPORTED_SYSTEM was *not* supp=
osed
to  or intended get rid of the EoL messaging *completely*.

I conclude that the mechanism indeed 'works as intended' on the above basis,
but I believe there is some messaging improvements to be made, as I can see=
 how
"silence this message" could be taken to mean "not see any message about th=
is
EoL condition *at all*", rather than "just remove the messaging about being
able to use the ALLOW_UNSUPPORTED_SYSTEM variable"

I would propose a simple change such as:

- No support will be provided if you *silence this message* by defining
ALLOW_UNSUPPORTED_SYSTEM.
+ No support will be provided if you *override this error* by defining
ALLOW_UNSUPPORTED_SYSTEM in /etc/make.conf

--=20
You are receiving this mail because:
You are on the CC list for the bug.=



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?bug-242619-7788-PrrPiZFYZq>