From owner-freebsd-hackers  Wed Dec 11 17:16:59 2002
Delivered-To: freebsd-hackers@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP
	id 7D50F37B401; Wed, 11 Dec 2002 17:16:58 -0800 (PST)
Received: from salmon.maths.tcd.ie (salmon.maths.tcd.ie [134.226.81.11])
	by mx1.FreeBSD.org (Postfix) with SMTP
	id 54E8E43EC5; Wed, 11 Dec 2002 17:16:57 -0800 (PST)
	(envelope-from iedowse@maths.tcd.ie)
Received: from walton.maths.tcd.ie by salmon.maths.tcd.ie with SMTP
          id <aa58562@salmon>; 12 Dec 2002 01:16:55 +0000 (GMT)
To: Luigi Rizzo <luigi@FreeBSD.ORG>
Cc: Alexander Langer <alex@big.endian.de>,
	Patrick Soltani <psoltani@ultradns.com>, freebsd-hackers@FreeBSD.ORG
Subject: Re: panic: icmp_error: bad length 
In-Reply-To: Your message of "Wed, 11 Dec 2002 17:02:27 PST."
             <20021211170227.A79864@xorpc.icir.org> 
Date: Thu, 12 Dec 2002 01:16:54 +0000
From: Ian Dowse <iedowse@maths.tcd.ie>
Message-ID:  <200212120116.aa58562@salmon.maths.tcd.ie>
Sender: owner-freebsd-hackers@FreeBSD.ORG
Precedence: bulk
List-ID: <freebsd-hackers.FreeBSD.ORG>
List-Archive: <http://docs.freebsd.org/mail/> (Web Archive)
List-Help: <mailto:majordomo@FreeBSD.ORG?subject=help> (List Instructions)
List-Subscribe: <mailto:majordomo@FreeBSD.ORG?subject=subscribe%20freebsd-hackers>
List-Unsubscribe: <mailto:majordomo@FreeBSD.ORG?subject=unsubscribe%20freebsd-hackers>
X-Loop: FreeBSD.ORG

In message <20021211170227.A79864@xorpc.icir.org>, Luigi Rizzo writes:
>the diagnosis looks reasonable, though i do not remember changing
>anything related to this between 4.6 and 4.7 so i wonder why the
>error did not appear in earlier versions of the code.

Yes strange - actually, it looks like the "THERE IS NO FUNCTIONAL
OR EXTERNAL API CHANGE IN THIS COMMIT" commit may be to blame :-)
Some fragments below.

Ian

bridge.c 1.16.2.2:
+#ifdef PFIL_HOOKS
...
-        * before calling the firewall, swap fields the same as IP does.
-        * here we assume the pkt is an IP one and the header is contiguous
...
-       ip = mtod(m0, struct ip *);
-       NTOHS(ip->ip_len);
-       NTOHS(ip->ip_off);

ip_fw.c 1.131.2.34:
-       if (0 && BRIDGED) { /* not yet... */
-           offset = (ntohs(ip->ip_off) & IP_OFFMASK);
+       if (BRIDGED) { /* bridged packets are as on the wire */
+           ip_off = ntohs(ip->ip_off);
            ip_len = ntohs(ip->ip_len);
 	} else {


To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-hackers" in the body of the message