From owner-svn-src-all@FreeBSD.ORG  Sat Aug 17 16:24:32 2013
Return-Path: <owner-svn-src-all@FreeBSD.ORG>
Delivered-To: svn-src-all@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits))
 (No client certificate requested)
 by hub.freebsd.org (Postfix) with ESMTP id A7234B6A;
 Sat, 17 Aug 2013 16:24:32 +0000 (UTC) (envelope-from jilles@stack.nl)
Received: from mx1.stack.nl (unknown [IPv6:2001:610:1108:5012::107])
 (using TLSv1 with cipher ADH-CAMELLIA256-SHA (256/256 bits))
 (No client certificate requested)
 by mx1.freebsd.org (Postfix) with ESMTPS id 6B1B02F32;
 Sat, 17 Aug 2013 16:24:32 +0000 (UTC)
Received: from snail.stack.nl (snail.stack.nl [IPv6:2001:610:1108:5010::131])
 by mx1.stack.nl (Postfix) with ESMTP id 66C1F1203C3;
 Sat, 17 Aug 2013 18:24:13 +0200 (CEST)
Received: by snail.stack.nl (Postfix, from userid 1677)
 id 3292928494; Sat, 17 Aug 2013 18:24:13 +0200 (CEST)
Date: Sat, 17 Aug 2013 18:24:13 +0200
From: Jilles Tjoelker <jilles@stack.nl>
To: Konstantin Belousov <kib@FreeBSD.org>
Subject: Re: svn commit: r254444 - stable/9/sys/kern
Message-ID: <20130817162412.GA42997@stack.nl>
References: <201308170831.r7H8VYOt019997@svn.freebsd.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <201308170831.r7H8VYOt019997@svn.freebsd.org>
User-Agent: Mutt/1.5.21 (2010-09-15)
Cc: svn-src-stable@freebsd.org, svn-src-all@freebsd.org,
 src-committers@freebsd.org, svn-src-stable-9@freebsd.org
X-BeenThere: svn-src-all@freebsd.org
X-Mailman-Version: 2.1.14
Precedence: list
List-Id: "SVN commit messages for the entire src tree \(except for &quot;
 user&quot; and &quot; projects&quot; \)" <svn-src-all.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/svn-src-all>,
 <mailto:svn-src-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-all>
List-Post: <mailto:svn-src-all@freebsd.org>
List-Help: <mailto:svn-src-all-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-all>,
 <mailto:svn-src-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sat, 17 Aug 2013 16:24:32 -0000

On Sat, Aug 17, 2013 at 08:31:34AM +0000, Konstantin Belousov wrote:
> Author: kib
> Date: Sat Aug 17 08:31:34 2013
> New Revision: 254444
> URL: http://svnweb.freebsd.org/changeset/base/254444

> Log:
>   MFC r253969:
>   Do not override the ENOENT error for the empty path, or EFAULT errors
>   from copyins, with the relative lookup check.

> Modified:
>   stable/9/sys/kern/vfs_lookup.c
> Directory Properties:
>   stable/9/sys/   (props changed)

> Modified: stable/9/sys/kern/vfs_lookup.c
> ==============================================================================
> --- stable/9/sys/kern/vfs_lookup.c	Sat Aug 17 08:08:58 2013	(r254443)
> +++ stable/9/sys/kern/vfs_lookup.c	Sat Aug 17 08:31:34 2013	(r254444)
> @@ -175,7 +175,7 @@ namei(struct nameidata *ndp)
>  	 * not an absolute path, and not containing '..' components) to
>  	 * a real file descriptor, not the pseudo-descriptor AT_FDCWD.
>  	 */
> -	if (IN_CAPABILITY_MODE(td)) {
> +	if (error = 0 && IN_CAPABILITY_MODE(td)) {
>  		ndp->ni_strictrelative = 1;
>  		if (ndp->ni_dirfd == AT_FDCWD)
>  			error = ECAPMODE;

I take it this should be error == 0 instead of error = 0?

-- 
Jilles Tjoelker