From owner-freebsd-net@FreeBSD.ORG  Thu Mar 27 12:17:04 2014
Return-Path: <owner-freebsd-net@FreeBSD.ORG>
Delivered-To: freebsd-net@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115])
 (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits))
 (No client certificate requested)
 by hub.freebsd.org (Postfix) with ESMTPS id 14BE47BD;
 Thu, 27 Mar 2014 12:17:04 +0000 (UTC)
Received: from mail-qa0-x22a.google.com (mail-qa0-x22a.google.com
 [IPv6:2607:f8b0:400d:c00::22a])
 (using TLSv1 with cipher ECDHE-RSA-RC4-SHA (128/128 bits))
 (Client CN "smtp.gmail.com",
 Issuer "Google Internet Authority G2" (verified OK))
 by mx1.freebsd.org (Postfix) with ESMTPS id B675F966;
 Thu, 27 Mar 2014 12:17:03 +0000 (UTC)
Received: by mail-qa0-f42.google.com with SMTP id k15so3728530qaq.29
 for <multiple recipients>; Thu, 27 Mar 2014 05:17:02 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113;
 h=mime-version:in-reply-to:references:date:message-id:subject:from:to
 :cc:content-type;
 bh=soOHARjwUgZbz1MH4FhK5NOqAJwLa4NS17mbGOY3Sao=;
 b=u8KEbeg3jqvExyONwsr+7PsHhsAHXtva2QTCbjlFahaAdbfF4abRxXtrQyLjv42qwW
 Nccs5V+zwDKaHLH92JeZbYmY/fD/FXBQ4NPRlmKVzygwKIJWPFzr0SMFQYOtd4GGAeTy
 Ehi6ppuya7VgoM+9KB/LNBV8F2xUBQBwpuhWeVDyGOQRcPAAXBeCpE9fsR4vHDHo5Z+y
 e2sonHffIHZ3kmRW9ILDPnsNzwIc33lEPO2P9uX+o4IYgIKrXgjFBgiMxM6k3Dxa/kLP
 1IQhhotSn6oICLy7shSVgf+OPBsfmFr17TzxCQgPhFRPB0woq9XtNeF50uIVgLdpfDr3
 L53A==
MIME-Version: 1.0
X-Received: by 10.224.57.72 with SMTP id b8mr1526381qah.41.1395922622731; Thu,
 27 Mar 2014 05:17:02 -0700 (PDT)
Received: by 10.96.79.97 with HTTP; Thu, 27 Mar 2014 05:17:02 -0700 (PDT)
In-Reply-To: <1353469098.1239101.1395880303531.JavaMail.root@uoguelph.ca>
References: <CAB2_NwA-zLnJh7Teqx4eQ-Tkc8bjx2qL0JMZeZqvSzJZ4mx4cg@mail.gmail.com>
 <1353469098.1239101.1395880303531.JavaMail.root@uoguelph.ca>
Date: Thu, 27 Mar 2014 09:17:02 -0300
Message-ID: <CAB2_NwDb27s2nnP_J7EAmkU8Ee4Vc_5-WJq9VwYJsDcU4_nr3Q@mail.gmail.com>
Subject: Re: 9.2 ixgbe tx queue hang
From: Christopher Forgeron <csforgeron@gmail.com>
To: Rick Macklem <rmacklem@uoguelph.ca>
Content-Type: text/plain; charset=ISO-8859-1
X-Content-Filtered-By: Mailman/MimeDel 2.1.17
Cc: FreeBSD Net <freebsd-net@freebsd.org>,
 Garrett Wollman <wollman@freebsd.org>, Jack Vogel <jfvogel@gmail.com>,
 Markus Gebert <markus.gebert@hostpoint.ch>
X-BeenThere: freebsd-net@freebsd.org
X-Mailman-Version: 2.1.17
Precedence: list
List-Id: Networking and TCP/IP with FreeBSD <freebsd-net.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/freebsd-net>,
 <mailto:freebsd-net-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-net/>
List-Post: <mailto:freebsd-net@freebsd.org>
List-Help: <mailto:freebsd-net-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-net>,
 <mailto:freebsd-net-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Thu, 27 Mar 2014 12:17:04 -0000

On Wed, Mar 26, 2014 at 9:31 PM, Rick Macklem <rmacklem@uoguelph.ca> wrote:

>
> ie. I've suggested:
>     ifp->if_hw_tsomax = min(32 * MCLBYTES - (ETHER_HDR_LEN +
> ETHER_VLAN_ENCAP_LEN),
>          IP_MAXPACKET);
> - I put the min() in just so it wouldn't break if MCLBYTES is increased
> someday.
>

I like the added safety for future changes - Good forward thinking. I'll
adjust my testing code to reflect this.