From owner-freebsd-stable@FreeBSD.ORG Wed May 16 19:56:04 2012 Return-Path: Delivered-To: freebsd-stable@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id D44AC1065670 for ; Wed, 16 May 2012 19:56:04 +0000 (UTC) (envelope-from andrey@zonov.org) Received: from mail-lb0-f182.google.com (mail-lb0-f182.google.com [209.85.217.182]) by mx1.freebsd.org (Postfix) with ESMTP id 4F5B98FC18 for ; Wed, 16 May 2012 19:56:03 +0000 (UTC) Received: by lbon10 with SMTP id n10so1109846lbo.13 for ; Wed, 16 May 2012 12:56:03 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=message-id:date:from:user-agent:mime-version:to:subject :content-type:x-gm-message-state; bh=GLlRweeauben+lEgxnWYR914DgX6bO+inEKL4HC2Udo=; b=kBjwLSwfD7eZHX1naEwXWrMQfAv4z/J4QfaHpjXwXbsYwKalmJgOSV9evydkEU5NCN vUtGj6sWyVevr1eseslF2ZJ8jLyyrVV0fyrsizxO84ftaHvEx8gLwcRcrFJRfhq4RZYO 7qaIWh8qQpx26AuoADJ1iIvxKlR62nXcsTvghwCS7DRy3+dZsUM+AzEXyY4zaVY6SteM bv97bJVlsM4Qz/ynXKNmoV7OiqMi69MF8GGVKfqiFGzNmymZXZaEAGXvh0heKPk8aYWZ SLnNGLpLx7WP+FRdcEco/6zQOjpXTln29BthFqqBB74NYL9+NrIjoKMfX58UL6asTLwz zo9g== Received: by 10.112.26.165 with SMTP id m5mr1966865lbg.15.1337198163006; Wed, 16 May 2012 12:56:03 -0700 (PDT) Received: from zont-osx.local (ppp95-165-141-253.pppoe.spdop.ru. [95.165.141.253]) by mx.google.com with ESMTPS id h6sm4067071lbl.13.2012.05.16.12.56.02 (version=SSLv3 cipher=OTHER); Wed, 16 May 2012 12:56:02 -0700 (PDT) Message-ID: <4FB4064F.2020601@zonov.org> Date: Wed, 16 May 2012 23:55:59 +0400 From: Andrey Zonov User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.7; rv:12.0) Gecko/20120428 Thunderbird/12.0.1 MIME-Version: 1.0 To: freebsd-stable Content-Type: multipart/mixed; boundary="------------000401070709000005020208" X-Gm-Message-State: ALoCoQkwZ1o2+w5OB+S9EMwrrE5uI5/3iEUf7zZo4nPmPBTypXFmxOegsC5nqWE7reMxLqjoxQOG Subject: powerd isn't correct count load X-BeenThere: freebsd-stable@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Production branch of FreeBSD source code List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 16 May 2012 19:56:04 -0000 This is a multi-part message in MIME format. --------------000401070709000005020208 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Hi, I just ran powerd(8) in verbose mode and found that it isn't correct count load. # powerd -v powerd: unable to determine AC line status load 323%, current freq 2409 MHz ( 0), wanted freq 4818 MHz load 222%, current freq 2409 MHz ( 0), wanted freq 4818 MHz load 213%, current freq 2409 MHz ( 0), wanted freq 4818 MHz load 151%, current freq 2409 MHz ( 0), wanted freq 4818 MHz load 170%, current freq 2409 MHz ( 0), wanted freq 4818 MHz I think load should be divided by the number of CPUs. Attached patch solves the problem. -- Andrey Zonov --------------000401070709000005020208 Content-Type: text/plain; charset=UTF-8; x-mac-type="0"; x-mac-creator="0"; name="powerd.c.patch" Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename="powerd.c.patch" Index: usr.sbin/powerd/powerd.c =================================================================== --- usr.sbin/powerd/powerd.c (revision 235394) +++ usr.sbin/powerd/powerd.c (working copy) @@ -168,6 +168,7 @@ *load += 100 - (cp_times[cpu * CPUSTATES + CP_IDLE] - cp_times_old[cpu * CPUSTATES + CP_IDLE]) * 100 / total; } + *load /= ncpus; } memcpy(cp_times_old, cp_times, cp_times_len); --------------000401070709000005020208--