From owner-freebsd-stable@FreeBSD.ORG  Wed Aug 24 19:24:36 2011
Return-Path: <owner-freebsd-stable@FreeBSD.ORG>
Delivered-To: freebsd-stable@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 26136106566B
	for <freebsd-stable@freebsd.org>; Wed, 24 Aug 2011 19:24:36 +0000 (UTC)
	(envelope-from slw@zxy.spb.ru)
Received: from zxy.spb.ru (zxy.spb.ru [195.70.199.98])
	by mx1.freebsd.org (Postfix) with ESMTP id 876E08FC13
	for <freebsd-stable@freebsd.org>; Wed, 24 Aug 2011 19:24:35 +0000 (UTC)
Received: from slw by zxy.spb.ru with local (Exim 4.69 (FreeBSD))
	(envelope-from <slw@zxy.spb.ru>)
	id 1QwJ4A-000JKR-7r; Wed, 24 Aug 2011 23:24:46 +0400
Date: Wed, 24 Aug 2011 23:24:46 +0400
From: Slawa Olhovchenkov <slw@zxy.spb.ru>
To: Kostik Belousov <kostikbel@gmail.com>
Message-ID: <20110824192446.GB48394@zxy.spb.ru>
References: <20110824181907.GA48394@zxy.spb.ru>
	<20110824190703.GY17489@deviant.kiev.zoral.com.ua>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20110824190703.GY17489@deviant.kiev.zoral.com.ua>
User-Agent: Mutt/1.5.20 (2009-06-14)
X-SA-Exim-Connect-IP: <locally generated>
X-SA-Exim-Mail-From: slw@zxy.spb.ru
X-SA-Exim-Scanned: No (on zxy.spb.ru); SAEximRunCond expanded to false
Cc: freebsd-stable@freebsd.org
Subject: Re: sigwait return 4
X-BeenThere: freebsd-stable@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: Production branch of FreeBSD source code <freebsd-stable.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-stable>, 
	<mailto:freebsd-stable-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-stable>
List-Post: <mailto:freebsd-stable@freebsd.org>
List-Help: <mailto:freebsd-stable-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-stable>,
	<mailto:freebsd-stable-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Wed, 24 Aug 2011 19:24:36 -0000

On Wed, Aug 24, 2011 at 10:07:03PM +0300, Kostik Belousov wrote:

> On Wed, Aug 24, 2011 at 10:19:07PM +0400, Slawa Olhovchenkov wrote:
> > System is 8.2-RELEASE (GENERIC), amd64.
> > Application -- i386 for freebsd7.
> > 
> > In ktrace dump I find some strange result:
> > 
> >  22951 100556 kas-milter CALL  sigwait(0xffdfdf80,0xffdfdf7c)
> >  22951 100556 kas-milter RET   sigwait 4
> >  22951 100556 kas-milter PSIG  SIGUSR2 caught handler=0x804c0f0 mask=0x4003 code=0x0
> > 
> > RET   sigwait 4 confused me, and, I think, confused application too.
> > 
> > man sigwait:
> > 
> > ERRORS
> >      The sigwait() system call will fail if:
> > 
> >      [EINVAL]           The set argument specifies one or more invalid signal
> >                         numbers.
> > 
> >      [EFAULT]           Any arguments point outside the allocated address
> >                         space or there is a memory protection fault.
> > 
> > 
> > How sigwait can return '4'?
> > May be EINTR, converted from ERESTART? But kern_sigtimedwait from sigwait must 
> > be called with timeout == NULL...
> > 
> 
> What should the system do for a delivered signal not present in the set ?
> I guess this is the case of your ktrace.
> 
> Looking at the SUSv4, I see no mention of the situation, but in Oracle
> SunOS 5.10 man page for sigwait(2), it is said explicitely
> EINTR The wait was interrupted by an unblocked, caught signal.

I don't think you right in this case.
This is kas-milter and in this thread (this is multi-thread
application) kas-milter wait for USR2 for reload config.

System return from sigwait only on USR2, but not each return w/
non-zero return code.

On freebsd7 this application don't complain about sigwait's return value.