Date: Thu, 22 Oct 2015 07:57:48 -0700 From: Bryan Drewery <bdrewery@FreeBSD.org> To: Alexey Dokuchaev <danfe@FreeBSD.org> Cc: "ports-committers@freebsd.org" <ports-committers@freebsd.org>, "svn-ports-all@freebsd.org" <svn-ports-all@freebsd.org>, "svn-ports-head@freebsd.org" <svn-ports-head@freebsd.org> Subject: Re: svn commit: r399935 - head/Mk Message-ID: <5B5081B7-A938-48F2-9F32-7C8678DD27BA@FreeBSD.org> In-Reply-To: <20151022142737.GA47314@FreeBSD.org> References: <201510212149.t9LLnkuH020681@repo.freebsd.org> <20151022083439.GA98806@FreeBSD.org> <EF0F6824-3B29-4081-A1EF-3358C01E4EF5@FreeBSD.org> <20151022142737.GA47314@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
> On Oct 22, 2015, at 07:27, Alexey Dokuchaev <danfe@FreeBSD.org> wrote: >=20 > On Thu, Oct 22, 2015 at 07:17:44AM -0700, Bryan Drewery wrote: >>>> On Oct 22, 2015, at 01:34, Alexey Dokuchaev <danfe@FreeBSD.org> wrote: >>>> On Wed, Oct 21, 2015 at 09:49:46PM +0000, Bryan Drewery wrote: >>>> New Revision: 399935 >>>> URL: https://svnweb.freebsd.org/changeset/ports/399935 >>>>=20 >>>> Log: >>>> Revert r399921 for now due to fallout with libclc using ninja. >>>>=20 >>>> [...] >>>> -.if defined(PACKAGE_BUILDING) >>>> -MAKE_ARGS+=3D V=3D1 >>>> -.endif >>>=20 >>> I've expected that something like this will bite us if we go the MAKEARG= S+=3D >>> V=3D1 path [1] for obtaining verbose logs for package builds. (I didn't= know >>> you'be been working on it; it would be nice if you'd joined that discuss= ion >>> back in September.) >>=20 >> I wasn't. It was just from a quick discussion on irc due to a build failu= re >> where hiding the rules was problematic. >>=20 >>> You can try grepping configure script for version and --disable-silent-r= ules >>> option as a safer alternative to always passing V=3D1 to make(1). >>=20 >> Yes that is what we will have to do. >=20 > Nice; feel free to add me on reviewer's list when you have a patch ready. := ) >=20 >=20 I definitely made a mistake rushing it in. Someone else mentioned potential p= roblems too. FWIW I did schedule on unrelated exp-run before this yesterday.= I really didn't expect things to have GNU_CONFIGURE and ninja!=
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?5B5081B7-A938-48F2-9F32-7C8678DD27BA>