Date: Thu, 4 Feb 2016 17:06:08 +1100 From: Kubilay Kocak <koobs@FreeBSD.org> To: Sunpoet Po-Chuan Hsieh <sunpoet@FreeBSD.org>, ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Subject: Re: svn commit: r407978 - head/dns/py-py3dns Message-ID: <56B2EA50.2070205@FreeBSD.org> In-Reply-To: <201602032054.u13KsXim088211@repo.freebsd.org> References: <201602032054.u13KsXim088211@repo.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On 4/02/2016 7:54 AM, Sunpoet Po-Chuan Hsieh wrote: > Author: sunpoet > Date: Wed Feb 3 20:54:33 2016 > New Revision: 407978 > URL: https://svnweb.freebsd.org/changeset/ports/407978 > > Log: > - Sort knobs > - Remove incorrect and outdated PYTHON_REL check > - Do not silence test message > > Modified: > head/dns/py-py3dns/Makefile > > Modified: head/dns/py-py3dns/Makefile > ============================================================================== > --- head/dns/py-py3dns/Makefile Wed Feb 3 20:54:28 2016 (r407977) > +++ head/dns/py-py3dns/Makefile Wed Feb 3 20:54:33 2016 (r407978) > @@ -17,20 +17,11 @@ LICENSE_PERMS= dist-mirror dist-sell pkg > > TEST_DEPENDS= ${PYTHON_PKGNAMEPREFIX}pytest>=0:${PORTSDIR}/devel/py-pytest > > -USES= python:3.3+ > -USE_PYTHON= autoplist distutils > - > NO_ARCH= yes > - > -.include <bsd.port.pre.mk> > - > -.if ${PYTHON_REL} == 3300 > -RUN_DEPENDS+= ${PYTHON_PKGNAMEPREFIX}ipaddress>=0:${PORTSDIR}/net/py-ipaddress > -.elif ${PYTHON_REL} <= 3200 > -RUN_DEPENDS+= ${PYTHON_PKGNAMEPREFIX}ipaddr>=0:${PORTSDIR}/devel/py-ipaddr > -.endif > +USE_PYTHON= autoplist distutils > +USES= python:3.3+ Removing the 3300 check breaks the port, which is what r407821 and r407820 fixed: https://svnweb.freebsd.org/changeset/ports/407821 https://svnweb.freebsd.org/changeset/ports/407820 This causes a regression on 3.3 I'm also -1 on removing declarations of which python versions a package supports, whether or not we have them in the tree. If a package supports 3.2+, we remove information, and make the dependency declaration incorrect, by changing it to 3.3+. Dependencies (particularly for python ports) are declarative, not imperative, with the framework then deriving which lang/pythonXY ports match, or are suitable. > do-test: > - @cd ${WRKSRC} && ${PYTHON_CMD} -m pytest > + cd ${WRKSRC}/ && ${PYTHON_CMD} -m pytest > > -.include <bsd.port.post.mk> > +.include <bsd.port.mk> >
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?56B2EA50.2070205>