From owner-svn-doc-head@freebsd.org Sat Jun 30 05:56:33 2018 Return-Path: Delivered-To: svn-doc-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 706EF101E15B; Sat, 30 Jun 2018 05:56:33 +0000 (UTC) (envelope-from eadler@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "mxrelay.nyi.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 1644D703CB; Sat, 30 Jun 2018 05:56:33 +0000 (UTC) (envelope-from eadler@FreeBSD.org) Received: from repo.freebsd.org (repo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:0]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id E82413FEC; Sat, 30 Jun 2018 05:56:32 +0000 (UTC) (envelope-from eadler@FreeBSD.org) Received: from repo.freebsd.org ([127.0.1.37]) by repo.freebsd.org (8.15.2/8.15.2) with ESMTP id w5U5uWbG095654; Sat, 30 Jun 2018 05:56:32 GMT (envelope-from eadler@FreeBSD.org) Received: (from eadler@localhost) by repo.freebsd.org (8.15.2/8.15.2/Submit) id w5U5uWOu095653; Sat, 30 Jun 2018 05:56:32 GMT (envelope-from eadler@FreeBSD.org) Message-Id: <201806300556.w5U5uWOu095653@repo.freebsd.org> X-Authentication-Warning: repo.freebsd.org: eadler set sender to eadler@FreeBSD.org using -f From: Eitan Adler Date: Sat, 30 Jun 2018 05:56:32 +0000 (UTC) To: doc-committers@freebsd.org, svn-doc-all@freebsd.org, svn-doc-head@freebsd.org Subject: svn commit: r51933 - head/en_US.ISO8859-1/articles/committers-guide X-SVN-Group: doc-head X-SVN-Commit-Author: eadler X-SVN-Commit-Paths: head/en_US.ISO8859-1/articles/committers-guide X-SVN-Commit-Revision: 51933 X-SVN-Commit-Repository: doc MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-BeenThere: svn-doc-head@freebsd.org X-Mailman-Version: 2.1.26 Precedence: list List-Id: SVN commit messages for the doc tree for head List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 30 Jun 2018 05:56:33 -0000 Author: eadler Date: Sat Jun 30 05:56:32 2018 New Revision: 51933 URL: https://svnweb.freebsd.org/changeset/doc/51933 Log: Committers guide: wordsmith the section on maintainers - remove an aside about reading the mailing list. This is taken care of by the later sentence about reading revision history - use a slightly stronger admonition ("important" instead of "note") for the comments about not sending mail directly to the maintainer. - Refer explicitly to the 'MAINTAINERS' file at the root of the tree - Use the language of "asking for a review" instead of "sending the change to them" which, again, encourages a more public interaction. - Remove the weasel language "it may help" and just encourage people to scan the history Modified: head/en_US.ISO8859-1/articles/committers-guide/article.xml Modified: head/en_US.ISO8859-1/articles/committers-guide/article.xml ============================================================================== --- head/en_US.ISO8859-1/articles/committers-guide/article.xml Sat Jun 30 05:33:32 2018 (r51932) +++ head/en_US.ISO8859-1/articles/committers-guide/article.xml Sat Jun 30 05:56:32 2018 (r51933) @@ -2674,18 +2674,17 @@ Relnotes: yes probably little need to check with other committers before jumping in with a commit. Working on a bug in an area of the system which is clearly orphaned (and there are a few such - areas, to our shame), the same applies. Trying to modify - something which is clearly being actively maintained by someone - else (and it is only by watching the - repository-committers - mailing list that a developer can really get a feel for just - what is and is not) then consider sending the change to them - instead, just as a developer would have before becoming a + areas, to our shame), the same applies. When modifying + parts of the system which are maintained, formally, or + informally, consider asking for review just as a developer + would have before becoming a committer. For ports, contact the listed MAINTAINER in the - Makefile. For other parts of the - repository, if it is not clear who the active maintainer is, it - may help to scan the revision history to see who has committed + Makefile. + + To determine if an area of the tree is maintained, check the + MAINTAINERS file at the root of the tree. If nobody is listed, + scan the revision history to see who has committed changes in the past. An example script that lists each person who has committed to a given file along with the number of commits each person has made can be found at on @@ -2694,11 +2693,11 @@ Relnotes: yes unanswered or the committer otherwise indicates a lack of interest in the area affected, go ahead and commit it. - + Avoid sending private emails to maintainers. Other people might be interested in the conversation, not just the final output. - + If there is any doubt about a commit for any reason at all, have it reviewed before