From owner-cvs-all@FreeBSD.ORG Sun Sep 18 17:09:35 2005 Return-Path: X-Original-To: cvs-all@freebsd.org Delivered-To: cvs-all@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 5FD6516A428; Sun, 18 Sep 2005 17:09:35 +0000 (GMT) (envelope-from nate@root.org) Received: from www.cryptography.com (li-22.members.linode.com [64.5.53.22]) by mx1.FreeBSD.org (Postfix) with ESMTP id 0942F43D45; Sun, 18 Sep 2005 17:09:34 +0000 (GMT) (envelope-from nate@root.org) Received: from [10.0.0.250] (ppp-71-139-46-176.dsl.snfc21.pacbell.net [71.139.46.176]) by www.cryptography.com (8.12.8/8.12.8) with ESMTP id j8IH9co5015369 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NOT); Sun, 18 Sep 2005 10:09:38 -0700 Message-ID: <432D9F4B.9080902@root.org> Date: Sun, 18 Sep 2005 10:09:31 -0700 From: Nate Lawson User-Agent: Mozilla Thunderbird 1.0.6 (Windows/20050716) X-Accept-Language: en-us, en MIME-Version: 1.0 To: joao.barros@gmail.com References: <200509111928.j8BJSWci066427@repoman.freebsd.org> <70e8236f0509180715406f1f31@mail.gmail.com> In-Reply-To: <70e8236f0509180715406f1f31@mail.gmail.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: cvs-src@freebsd.org, src-committers@freebsd.org, Warner Losh , cvs-all@freebsd.org Subject: Re: cvs commit: src/sys/dev/pci pci.c X-BeenThere: cvs-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the entire tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 18 Sep 2005 17:09:35 -0000 Joao Barros wrote: > On 9/11/05, Warner Losh wrote: > >>imp 2005-09-11 19:28:31 UTC >> >> FreeBSD src repository >> >> Modified files: (Branch: RELENG_6) >> sys/dev/pci pci.c >> Log: >> Change the default of pci_do_powerstate to 0, per request from re@. >> The number of raid controllers that violate the WHQL seems to be >> growing in number and not isolated to old versions as previously >> thought. Though the numbers of these seen in the wild is still >> relatively small, they hang the system when parts of their devices are >> powered down. The one area that these parts appear often are in the >> higher end servers. As such, be conservative about powering down >> devices that have no driver attached by default. Until a better >> approach is proven in current, this is the prudent choice. >> >> Laptop users wishing the benefits of powering down devices with no >> drivers will now need to set hw.pci.do_powerstate=1 in their >> /boot/loader.conf file. Some users will have devices that will >> prevent this setting (hence the need to make it default 0). >> >> Approved by: re@ (scottl) >> >> Revision Changes Path >> 1.292.2.2 +2 -2 src/sys/dev/pci/pci.c > > I was reading the Release Notes for 6.0 on > http://www.freebsd.org/relnotes/6-STABLE/relnotes/i386/article.html > and noticed: > > 2.2.2 Hardware Support > > The acpi(4) driver now turns the ACPI and PCI devices off or to a > lower power state when suspending, and back on again when resuming. > This behavior can be disabled by setting the debug.acpi.do_powerstate > and hw.pci.do_powerstate sysctls to 0. > > Given this is the same tunable you changed back to 0 by default, does > that "when resuming" has anything to do with this last commit? If so, > it could still be mentioned the other way around, allowing people > wanting to, to enable the tunable :) You bring up a different point also, which is that ACPI should probably be set to match this same default for release. -- Nate