Date: Mon, 5 Oct 2009 18:26:37 +0100 (BST) From: Iain Hibbert <plunky@rya-online.net> To: Masoom Shaikh <masoom.shaikh@gmail.com> Cc: freebsd-bluetooth@freebsd.org Subject: Re: bluetooth.h, c++ include error Message-ID: <1254763597.419838.805.nullmailer@galant.ukfsn.org> In-Reply-To: <b10011eb0910050958j49eed45diee0c36f3947f094@mail.gmail.com> References: <b10011eb0910011142p480deee4j220ebb41623f58e0@mail.gmail.com> <b10011eb0910011232r13ddb42axd97a65b3cb025de9@mail.gmail.com> <b10011eb0910041042r7edd20afhf5ec42e652514b81@mail.gmail.com> <bb4a86c70910041126r3bfb7cc5w71281fb3b5f8ccd@mail.gmail.com> <b10011eb0910050958j49eed45diee0c36f3947f094@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On Mon, 5 Oct 2009, Masoom Shaikh wrote: > what i am requesting is just variable name change ;-) my tree is at > revision 197571, thus the patch i am presenting is also generated > against it reject this if you want patch against latest revision > > renamed second argument of bt_devfilter() from 'new' to 'dfnew'. df for > device filter to maintain uniformity renamed third argument from 'old' > to 'dfold'. style(9) mentions that for kernel include files exposed to userland (technically, this is always in userland but perhaps the same rules apply) the prototype tag arguments should be made safe, eg starting with a _ perhaps for much this reason.. so, my suggestion would be to use _new and _old etc.. iain (or, just don't use them, they are not especially required :)
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?1254763597.419838.805.nullmailer>