Date: Sun, 06 Jan 2008 13:32:37 -0700 (MST) From: "M. Warner Losh" <imp@bsdimp.com> To: jhb@freebsd.org Cc: gonzo@freebsd.org, perforce@freebsd.org Subject: Re: PERFORCE change 132497 for review Message-ID: <20080106.133237.1784683699.imp@bsdimp.com> In-Reply-To: <200801041343.19320.jhb@freebsd.org> References: <200801041711.m04HBGPG029002@repoman.freebsd.org> <20080104.111926.-108774279.imp@bsdimp.com> <200801041343.19320.jhb@freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
In message: <200801041343.19320.jhb@freebsd.org>
John Baldwin <jhb@freebsd.org> writes:
: On Friday 04 January 2008 01:19:26 pm M. Warner Losh wrote:
: > In message: <200801041711.m04HBGPG029002@repoman.freebsd.org>
: > Oleksandr Tymoshenko <gonzo@freebsd.org> writes:
: > : http://perforce.freebsd.org/chv.cgi?CH=132497
: > :
: > : Change 132497 by gonzo@gonzo_jeeves on 2008/01/04 17:11:07
: > :
: > : o I believe MK_ZFS is more appropriate variable to be checked
: > : in this case.
: >
: > I thought this was more a case of 'exclude all CDDL code' rather than
: > being tied to ZFS.
: >
: > Warner
:
: I dunno, I think gonzo@ might be right. It's ZFS support for fstat and I
: think disabling CDDL would disable ZFS as a side effect?
In any event, these changes should be made in head, not here.
Warner
: > : Affected files ...
: > :
: > : .. //depot/projects/mips2-jnpr/src/usr.bin/fstat/Makefile#2 edit
: > :
: > : Differences ...
: > :
: > : ==== //depot/projects/mips2-jnpr/src/usr.bin/fstat/Makefile#2 (text+ko)
: ====
: > :
: > : @@ -13,7 +13,7 @@
: > :
: > : CFLAGS+=-D_KVM_VNODE
: > :
: > : -.if ${MK_CDDL} != "no"
: > : +.if ${MK_ZFS} != "no"
: > : CFLAGS+= -DZFS
: > : OBJS+= zfs/zfs.o
: > : SUBDIR= zfs
: > :
: >
:
:
:
: --
: John Baldwin
:
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20080106.133237.1784683699.imp>