Date: Sat, 07 Sep 2019 11:52:17 +0000 From: bugzilla-noreply@freebsd.org To: ports-bugs@FreeBSD.org Subject: [Bug 240375] [NEW PORT] www/py-isso: A commenting server similar to Disqus Message-ID: <bug-240375-7788-c7ORkESPEj@https.bugs.freebsd.org/bugzilla/> In-Reply-To: <bug-240375-7788@https.bugs.freebsd.org/bugzilla/> References: <bug-240375-7788@https.bugs.freebsd.org/bugzilla/>
next in thread | previous in thread | raw e-mail | index | archive | help
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D240375 --- Comment #4 from Kubilay Kocak <koobs@FreeBSD.org> --- (In reply to Ren=C3=A9 Th=C3=BCmmler from comment #3) My pleasure Ren=C3=A9, you're welcome & very nice work A few nits: - No need for a PORTREVISION for a new (not yet committed port) - misaka has a max version pin, one must either declare that, or patch it o= ut. misaka>=3D2.0<3.0 should work - Upstream specifies =3D=3D2.7 as the environment marker, so match that (in= stead of (PYTHON_REL < 3000) where possible. In these "=3D=3D" cases, one can use <flavor>_RUN_DEPENDS helpers, like: py27_RUN_DEPENDS=3D foo \ bar - I'd use ${ETCDIR} rather than ${PREFIX}/etc in post-patch (it covers more= of the path), unless it makes the REINPLACE search/replace 'too' challenging or less readable. Likewise for post-install (use ETCDIR) - For sqlite3, does this actually need the "sqlite module in Python" ? If s= o, depend on databases/py-sqlite3 directly (we split that module out from the stdlib/language ports). If this is the case, remove sqlite:3 from USES --=20 You are receiving this mail because: You are the assignee for the bug.=
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?bug-240375-7788-c7ORkESPEj>