Skip site navigation (1)Skip section navigation (2)
Date:      Sat, 3 Oct 2015 19:37:42 +0000 (UTC)
From:      Mark Johnston <markj@FreeBSD.org>
To:        src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org
Subject:   svn commit: r288628 - head/sys/kern
Message-ID:  <201510031937.t93Jbgkk077518@repo.freebsd.org>

next in thread | raw e-mail | index | archive | help
Author: markj
Date: Sat Oct  3 19:37:41 2015
New Revision: 288628
URL: https://svnweb.freebsd.org/changeset/base/288628

Log:
  The return value of posix_fadvise(2) is just an error status, so
  sys_posix_fadvise() should simply return the errno (or 0) to syscallenter()
  rather than setting a return value.
  
  MFC after:	1 week

Modified:
  head/sys/kern/vfs_syscalls.c

Modified: head/sys/kern/vfs_syscalls.c
==============================================================================
--- head/sys/kern/vfs_syscalls.c	Sat Oct  3 19:27:52 2015	(r288627)
+++ head/sys/kern/vfs_syscalls.c	Sat Oct  3 19:37:41 2015	(r288628)
@@ -4663,7 +4663,6 @@ int
 sys_posix_fadvise(struct thread *td, struct posix_fadvise_args *uap)
 {
 
-	td->td_retval[0] = kern_posix_fadvise(td, uap->fd, uap->offset,
-	    uap->len, uap->advice);
-	return (0);
+	return (kern_posix_fadvise(td, uap->fd, uap->offset, uap->len,
+	    uap->advice));
 }



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201510031937.t93Jbgkk077518>