Skip site navigation (1)Skip section navigation (2)
Date:      Mon, 05 May 2014 21:42:15 +0400
From:      Andrey Chernov <ache@freebsd.org>
To:        "Pedro F. Giffuni" <pfg@FreeBSD.org>, src-committers@freebsd.org,  svn-src-all@freebsd.org, svn-src-head@freebsd.org
Subject:   Re: svn commit: r265367 - head/lib/libc/regex
Message-ID:  <5367CD77.40909@freebsd.org>
In-Reply-To: <201405051641.s45GfFje086423@svn.freebsd.org>
References:  <201405051641.s45GfFje086423@svn.freebsd.org>

next in thread | previous in thread | raw e-mail | index | archive | help
On 05.05.2014 20:41, Pedro F. Giffuni wrote:
> Log:
>   regex: Use calloc instead of malloc.
>   
>   Mostly to reduce differences with OpenBSD.

Please don't commit OpenBSD errors. Now you mix calloc() with the
realloc() for the same variable later which makes calloc() zeroing
pointless and waste of CPU.

-- 
http://ache.vniz.net/



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?5367CD77.40909>