From owner-svn-src-all@freebsd.org Thu Oct 17 21:08:48 2019 Return-Path: Delivered-To: svn-src-all@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id AFAD915DB31; Thu, 17 Oct 2019 21:08:48 +0000 (UTC) (envelope-from markjdb@gmail.com) Received: from mail-qt1-x82e.google.com (mail-qt1-x82e.google.com [IPv6:2607:f8b0:4864:20::82e]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 46vMGS47D2z3F8L; Thu, 17 Oct 2019 21:08:48 +0000 (UTC) (envelope-from markjdb@gmail.com) Received: by mail-qt1-x82e.google.com with SMTP id w14so5706993qto.9; Thu, 17 Oct 2019 14:08:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=QQs3SliRwbiyj8tsHxGfpsPhYDdTnPioAe1PynUb8X0=; b=bjs4XtoFignGD1eRlbDjNzJfNtMRhr9lQUOc0EwR1njeHblqsUVJ7zyuHbDhtRrGtc bWsY7GRaxIFJVxSRzYFAxwNZYPCKcjlffwc/pW70dnrHGYjnXECPTJQgJ/6Dxt8YfWeg u6TsMZI9RLcYlUSGd0rW2p/d4V7lth/zNCHcV/ivoRfEkIduI7GSU0CQCxYe3tG7KeuA DBFI9tLbWAkkehCgcZHytLyRp3AcP79t3goYVBeJmrN1pVGEkz9hFu432fLDPoQRszt9 PblZhMPzF5JWiEliY83Gyvwo7dox7jlwS1hq3iIyC32hnfU+jWpfs344q06cGmNpYTpF nsPg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:date:from:to:cc:subject:message-id :references:mime-version:content-disposition:in-reply-to:user-agent; bh=QQs3SliRwbiyj8tsHxGfpsPhYDdTnPioAe1PynUb8X0=; b=GgveXvLefs1Cdsb4ySnXs/S+2nFd3klKAB5DLtDPqMDkhxi5pju/IybHjZ8oRopHYS X99MaFefVvMQ8erggHja7Y5IBVUdoZfPtwCQyBZbJzrFEV9tgocPafNt/AfRy8rR+AfK F7/LjpJdyMCGfUx7PD2yv8ygG5IyIBFNURCZQqh8bSd4Rvpn/dDMsDHPgRLWDePD+Er4 h13xVFAXublW4dYR9zF4uMCeFFcNAkh31N8pTBT4AWIDZatLejntfucWoV3VMyzpDGV4 l+713DM6bZPaTF1ViFfZLhzshaG0trXOkVcuPe4PALolJIIEBdgVf0pBdpmmGzL/LCam LFXw== X-Gm-Message-State: APjAAAV5FbFKL9yM5S8RnA0/1N/FXcm1shWkhev+tmV9Yb0ALz4aaF2R Mm4ZcsQgDn81lEnZohgDZe/zuzY39uU= X-Google-Smtp-Source: APXvYqx4GbI5UfiMGt3VcWVTKdZjFtvuEejwJzuhmw5ASsxJAk4l7rlxZuYDP2p8I3p2R4xwhCxRYA== X-Received: by 2002:a0c:ee8f:: with SMTP id u15mr6302612qvr.0.1571346526725; Thu, 17 Oct 2019 14:08:46 -0700 (PDT) Received: from raichu (toroon0560w-lp130-05-69-158-183-252.dsl.bell.ca. [69.158.183.252]) by smtp.gmail.com with ESMTPSA id i30sm2277208qte.27.2019.10.17.14.08.45 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 17 Oct 2019 14:08:45 -0700 (PDT) Sender: Mark Johnston Date: Thu, 17 Oct 2019 17:08:38 -0400 From: Mark Johnston To: Alan Somers Cc: Ian Lepore , src-committers , svn-src-all , svn-src-head Subject: Re: svn commit: r352909 - in head: contrib/elftoolchain/nm usr.bin/nm Message-ID: <20191017210838.GA23659@raichu> References: <201909301728.x8UHS0QF070658@repo.freebsd.org> <20191017174801.GA6447@raichu> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.12.2 (2019-09-21) X-Rspamd-Queue-Id: 46vMGS47D2z3F8L X-Spamd-Bar: ----- Authentication-Results: mx1.freebsd.org; none X-Spamd-Result: default: False [-6.00 / 15.00]; NEURAL_HAM_MEDIUM(-1.00)[-0.998,0]; NEURAL_HAM_LONG(-1.00)[-1.000,0]; REPLY(-4.00)[] X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 17 Oct 2019 21:08:48 -0000 On Thu, Oct 17, 2019 at 01:05:42PM -0600, Alan Somers wrote: > On Thu, Oct 17, 2019 at 12:48 PM Ian Lepore wrote: > > > On Thu, 2019-10-17 at 12:17 -0600, Alan Somers wrote: > > > There might be something wrong with my environment: > > > /usr/include/libcasper.h is absent. But still, shouldn't the build > > > be > > > using the version from the source tree, instead of from the > > > environment? > > > -Alan > > > > > > > There should be copies of libcasper.h in your objdir: > > > > obj/arm.armv7/tmp/legacy/usr/include/libcasper.h > > obj/arm.armv7/tmp/usr/include/libcasper.h > > > > -- Ian > > > Uh, I found the problem. I had WITHOUT_CASPER=1 in /etc/src.conf. So the > problem is that nm can't build without casper. Perhaps the #include should > be guarded, as it is in usr.bin/kdump/kdump.c. But plenty of other > programs, like usr.bin/tail and usr.bin/wc, don't have such guards. And > looking at lib/libcasper/libcasper/Makefile, it seems as though libcasper.h > should be installed regardless. So I still need to figure out why it > wasn't installed on my system. Indeed, "make -C usr.bin/nm WITHOUT_CASPER=" builds fine for me. libcasper.h provides stub routines unless WITH_CASPER is defined in the preprocessor, so applications which make use of casper must define this symbol unless the make variable WITHOUT_CASPER is set.