Date: Sat, 07 Jul 2018 20:39:33 +0900 From: =?utf-8?B?5b6M6Jek5aSn5Zyw?= <daichigoto@icloud.com> To: Hiroki Sato <hrs@FreeBSD.org> Cc: daichi@FreeBSD.org, Eitan Adler <eadler@FreeBSD.org>, gnn@FreeBSD.org, src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r336028 - head/usr.bin/top Message-ID: <EA13C9AB-808A-4FDA-B68F-57E832AF6449@icloud.com> In-Reply-To: <20180707.085353.1746062843251989845.hrs@allbsd.org> References: <201807061207.w66C76CR043533@repo.freebsd.org> <20180707.085353.1746062843251989845.hrs@allbsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
> 2018/07/07 8:53=E3=80=81Hiroki Sato <hrs@FreeBSD.org>=E3=81=AE=E3=83=A1=E3= =83=BC=E3=83=AB: >=20 > Daichi GOTO <daichi@FreeBSD.org> wrote > in <201807061207.w66C76CR043533@repo.freebsd.org>: >=20 > da> Author: daichi > da> Date: Fri Jul 6 12:07:06 2018 > da> New Revision: 336028 > da> URL: https://svnweb.freebsd.org/changeset/base/336028 > da> > da> Log: > da> Changed to eliminate the upper limit of command length displayed > da> by "-a" and expand to match terminal width > da> > da> Reviewed by: eadler > da> Approved by: gnn (mentor) > da> Differential Revision: https://reviews.freebsd.org/D16083 > da> > da> Modified: > da> head/usr.bin/top/display.c > da> head/usr.bin/top/machine.c > da> head/usr.bin/top/screen.c > da> head/usr.bin/top/top.h >=20 > This change breaks displaying a prompt and messages in the > interactive mode by new_message() when typing "o" or "p", for > example. While r336031 fixed a warning in GCC, it does not fix the > problem itself. Please fix it. OK. I will fix this problem first. > I also think restructure of the buffer management is required first > if we want to eliminate the column width limitation. Using sbuf(9) > consistently may be better than incomplete conversion from static > arrays to malloc(). I understand. Switching to sbuf(9) is the next step. >=20 > -- Hiroki
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?EA13C9AB-808A-4FDA-B68F-57E832AF6449>