From owner-freebsd-commit Fri Aug 4 11:33:20 1995 Return-Path: commit-owner Received: (from majordom@localhost) by freefall.cdrom.com (8.6.11/8.6.6) id LAA24975 for commit-outgoing; Fri, 4 Aug 1995 11:33:20 -0700 Received: (from majordom@localhost) by freefall.cdrom.com (8.6.11/8.6.6) id LAA24962 for cvs-usrbin-outgoing; Fri, 4 Aug 1995 11:33:19 -0700 Received: from gndrsh.aac.dev.com (gndrsh.aac.dev.com [198.145.92.241]) by freefall.cdrom.com (8.6.11/8.6.6) with ESMTP id LAA24953 ; Fri, 4 Aug 1995 11:33:07 -0700 Received: (from rgrimes@localhost) by gndrsh.aac.dev.com (8.6.11/8.6.9) id LAA01716; Fri, 4 Aug 1995 11:32:55 -0700 From: "Rodney W. Grimes" Message-Id: <199508041832.LAA01716@gndrsh.aac.dev.com> Subject: Re: cvs commit: src/usr.bin/xinstall xinstall.c To: joerg@freefall.cdrom.com (Joerg Wunsch) Date: Fri, 4 Aug 1995 11:32:52 -0700 (PDT) Cc: CVS-commiters@freefall.cdrom.com, cvs-usrbin@freefall.cdrom.com In-Reply-To: <199508041713.KAA22437@freefall.cdrom.com> from "Joerg Wunsch" at Aug 4, 95 10:13:37 am X-Mailer: ELM [version 2.4 PL24] MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Content-Length: 781 Sender: commit-owner@FreeBSD.org Precedence: bulk > > joerg 95/08/04 10:13:37 > > Modified: usr.bin/xinstall xinstall.c > Log: > Make install not remove the target file if -s has been specified but > stripping failed (since the file has been a shell script, for > example). Ignoring error conditions from strip is not a good idea. Using -s option to install non binary files is a usage error. Removing the file if strip failed is probably not the right thing to do, but being silent about strip errors is not a good idea. > Closes PR # bin/645: "install -c -s" can't inst... > > Submitted by: hohmuth@inf.tu-dresden.de (Michael Hohmuth) > -- Rod Grimes rgrimes@gndrsh.aac.dev.com Accurate Automation Company Reliable computers for FreeBSD