Date: Wed, 2 Mar 2011 16:57:18 -0600 From: Brandon Gooch <jamesbrandongooch@gmail.com> To: Wesley Shields <wxs@freebsd.org> Cc: Bruce Cran <bruce@cran.org.uk>, freebsd-net@freebsd.org, Rui Paulo <rpaulo@freebsd.org> Subject: Re: Interface descriptions via pcap broken Message-ID: <AANLkTi=WJSronjjNhBvR0k7iN=ZcAjTAV%2BR23rT_1127@mail.gmail.com> In-Reply-To: <20110302215258.GA48643@atarininja.org> References: <1298961441.2888.2.camel@core.nessbank> <AANLkTik_JxT4G7SBsqEZYFvVDFJUFxzhmHaYj%2BrAN9P6@mail.gmail.com> <20110302194540.0000018f@unknown> <20110302215258.GA48643@atarininja.org>
next in thread | previous in thread | raw e-mail | index | archive | help
--0016e649c770b3a94d049d87d503 Content-Type: text/plain; charset=ISO-8859-1 On Wed, Mar 2, 2011 at 3:52 PM, Wesley Shields <wxs@freebsd.org> wrote: > On Wed, Mar 02, 2011 at 07:45:40PM +0000, Bruce Cran wrote: >> On Wed, 2 Mar 2011 13:40:57 -0600 >> Brandon Gooch <jamesbrandongooch@gmail.com> wrote: >> >> > BTW, if you give your devices descriptions, libpcap >> > starts to behave again; this could be a clue to the source of the bug >> > :/ >> >> 0xa5 is the malloc fill pattern when debugging is enabled, and >> having recently reinstalled FreeBSD I forgot to create the malloc.conf >> symlink. So something's reading from uninitialized memory. > > Does commit c65292b04b98d6a76d58c5a54ca8f81463bf24de in the libpcap git > tree look like it could help? I haven't checked in detail but I think it > might have never made it into a release yet? > > https://github.com/mcr/libpcap/commit/c65292b04b98d6a76d58c5a54ca8f81463bf24de > > -- WXS I applied the patch attached (diff'd against the code from the github link above), rebuilt libpcap and wireshark, and the problem described no longer exists. Thanks for looking at this wxs@! -Brandon --0016e649c770b3a94d049d87d503 Content-Type: application/octet-stream; name="libpcap-inet.c.diff" Content-Disposition: attachment; filename="libpcap-inet.c.diff" Content-Transfer-Encoding: base64 X-Attachment-Id: f_gksuho9c0 LS0tIGNvbnRyaWIvbGlicGNhcC9pbmV0LmMub3JpZwkyMDExLTAyLTAxIDIzOjU3OjMyLjAwMDAw MDAwMCAtMDYwMAorKysgY29udHJpYi9saWJwY2FwL2luZXQuYwkyMDExLTAzLTAyIDE2OjI0OjM0 LjAwMDAwMDAwMCAtMDYwMApAQCAtNDMxLDI2ICs0MzEsNTQgQEAKIAlzdHJsY3B5KGlmcmRlc2Mu aWZyX25hbWUsIG5hbWUsIHNpemVvZiBpZnJkZXNjLmlmcl9uYW1lKTsKIAlzID0gc29ja2V0KEFG X0lORVQsIFNPQ0tfREdSQU0sIDApOwogCWlmIChzID49IDApIHsKKyNpZmRlZiBfX0ZyZWVCU0Rf XworCQkvKgorCQkgKiBPbiBGcmVlQlNELCBpZiB0aGUgYnVmZmVyIGlzbid0IGJpZyBlbm91Z2gg Zm9yIHRoZQorCQkgKiBkZXNjcmlwdGlvbiwgdGhlIGlvY3RsIHN1Y2NlZWRzLCBidXQgdGhlIGRl c2NyaXB0aW9uCisJCSAqIGlzbid0IGNvcGllZCwgaWZyX2J1ZmZlci5sZW5ndGggaXMgc2V0IHRv IHRoZSBkZXNjcmlwdGlvbgorCQkgKiBsZW5ndGgsIGFuZCBpZnJfYnVmZmVyLmJ1ZmZlciBpcyBz ZXQgdG8gTlVMTC4KKwkJICovCiAJCWZvciAoOzspIHsKIAkJCWZyZWUoZGVzY3JpcHRpb24pOwog CQkJaWYgKChkZXNjcmlwdGlvbiA9IG1hbGxvYyhkZXNjcmxlbikpICE9IE5VTEwpIHsKLSNpZmRl ZiBfX0ZyZWVCU0RfXwogCQkJCWlmcmRlc2MuaWZyX2J1ZmZlci5idWZmZXIgPSBkZXNjcmlwdGlv bjsKIAkJCQlpZnJkZXNjLmlmcl9idWZmZXIubGVuZ3RoID0gZGVzY3JsZW47Ci0jZWxzZSAvKiBf X0ZyZWVCU0RfXyAqLwotCQkJCWlmcmRlc2MuaWZyX2RhdGEgPSAoY2FkZHJfdClkZXNjcmlwdGlv bjsKLSNlbmRpZiAvKiBfX0ZyZWVCU0RfXyAqLwotCQkJCWlmIChpb2N0bChzLCBTSU9DR0lGREVT Q1IsICZpZnJkZXNjKSA9PSAwKQotCQkJCQlicmVhazsKLSNpZmRlZiBfX0ZyZWVCU0RfXwotCQkJ CWVsc2UgaWYgKGVycm5vID09IEVOQU1FVE9PTE9ORykKLQkJCQkJZGVzY3JsZW4gPSBpZnJkZXNj Lmlmcl9idWZmZXIubGVuZ3RoOwotI2VuZGlmIC8qIF9fRnJlZUJTRF9fICovCi0JCQkJZWxzZQor CQkJCWlmIChpb2N0bChzLCBTSU9DR0lGREVTQ1IsICZpZnJkZXNjKSA9PSAwKSB7CisJCQkJCWlm IChpZnJkZXNjLmlmcl9idWZmZXIuYnVmZmVyID09CisJCQkJCSAgICBkZXNjcmlwdGlvbikKKwkJ CQkJCWJyZWFrOworCQkJCQllbHNlCisJCQkJCQlkZXNjcmxlbiA9IGlmcmRlc2MuaWZyX2J1ZmZl ci5sZW5ndGg7CisJCQkJfSBlbHNlIHsKKwkJCQkJLyoKKwkJCQkJICogRmFpbGVkIHRvIGdldCBp bnRlcmZhY2UgZGVzY3JpcHRpb24uCisJCQkJCSAqLworCQkJCQlmcmVlKGRlc2NyaXB0aW9uKTsK KwkJCQkJZGVzY3JpcHRpb24gPSBOVUxMOwogCQkJCQlicmVhazsKKwkJCQl9CiAJCQl9IGVsc2UK IAkJCQlicmVhazsKIAkJfQorI2Vsc2UgLyogX19GcmVlQlNEX18gKi8KKwkJLyoKKwkJICogVGhl IG9ubHkgb3RoZXIgT1MgdGhhdCBjdXJyZW50bHkgc3VwcG9ydHMKKwkJICogU0lPQ0dJRkRFU0NS IGlzIE9wZW5CU0QsIGFuZCBpdCBoYXMgbm8gd2F5CisJCSAqIHRvIGdldCB0aGUgZGVzY3JpcHRp b24gbGVuZ3RoIC0gaXQncyBjbGFtcGVkCisJCSAqIHRvIGEgbWF4aW11bSBvZiBJRkRFU0NSU0la RS4KKwkJICovCisJCWlmICgoZGVzY3JpcHRpb24gPSBtYWxsb2MoZGVzY3JsZW4pKSAhPSBOVUxM KSB7CisJCQlpZnJkZXNjLmlmcl9kYXRhID0gKGNhZGRyX3QpZGVzY3JpcHRpb247CisJCQlpZiAo aW9jdGwocywgU0lPQ0dJRkRFU0NSLCAmaWZyZGVzYykgIT0gMCkgeworCQkJCS8qCisJCQkJICog RmFpbGVkIHRvIGdldCBpbnRlcmZhY2UgZGVzY3JpcHRpb24uCisJCQkJICovCisJCQkJZnJlZShk ZXNjcmlwdGlvbik7CisJCQkJZGVzY3JpcHRpb24gPSBOVUxMOworCQkJfQorCQl9IGVsc2UKKwkJ CWJyZWFrOworI2VuZGlmIC8qIF9fRnJlZUJTRF9fICovCiAJCWNsb3NlKHMpOwogCQlpZiAoZGVz Y3JpcHRpb24gIT0gTlVMTCAmJiBzdHJsZW4oZGVzY3JpcHRpb24pID09IDApIHsKIAkJCWZyZWUo ZGVzY3JpcHRpb24pOwo= --0016e649c770b3a94d049d87d503--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?AANLkTi=WJSronjjNhBvR0k7iN=ZcAjTAV%2BR23rT_1127>