From owner-freebsd-ports@freebsd.org Wed Apr 14 18:43:04 2021 Return-Path: Delivered-To: freebsd-ports@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 3816B5E46BE for ; Wed, 14 Apr 2021 18:43:04 +0000 (UTC) (envelope-from danm@prime.gushi.org) Received: from mailman.nyi.freebsd.org (unknown [127.0.1.3]) by mx1.freebsd.org (Postfix) with ESMTP id 4FLBDl704wz3rFW for ; Wed, 14 Apr 2021 18:43:03 +0000 (UTC) (envelope-from danm@prime.gushi.org) Received: by mailman.nyi.freebsd.org (Postfix) id EFEE45E46BD; Wed, 14 Apr 2021 18:43:03 +0000 (UTC) Delivered-To: ports@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id EFB165E4A1D for ; Wed, 14 Apr 2021 18:43:03 +0000 (UTC) (envelope-from danm@prime.gushi.org) Received: from prime.gushi.org (prime.gushi.org [IPv6:2620:137:6000:10::142]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "prime.gushi.org", Issuer "RapidSSL TLS DV RSA Mixed SHA256 2020 CA-1" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4FLBDk3fDdz3qyR for ; Wed, 14 Apr 2021 18:43:02 +0000 (UTC) (envelope-from danm@prime.gushi.org) Received: from prime.gushi.org (localhost [127.0.0.1]) by prime.gushi.org (8.16.1/8.16.1) with ESMTPS id 13EIgv7r002077 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NO) for ; Wed, 14 Apr 2021 11:42:58 -0700 (PDT) (envelope-from danm@prime.gushi.org) DKIM-Filter: OpenDKIM Filter v2.10.3 prime.gushi.org 13EIgv7r002077 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gushi.org; s=prime2014; t=1618425779; bh=29Sg06zCQZSZNd5ezABVv5UzN6ffJ+aA0glRa9IOw3U=; h=Date:From:To:Subject; z=Date:=20Wed,=2014=20Apr=202021=2011:42:55=20-0700=20(PDT)|From:=2 0"Dan=20Mahoney=20(Gushi)"=20|To:=20ports@freeb sd.org|Subject:=20rclint:=20two=20thoughts; b=cHBiY5ie//t7A15dH9E64c/Feutm9CQc7zlhC/rpEULnVQC9SrXcHX5p5foCL8w0Y pvuTW8v++05hJjO4/TGzKTCOGRYJ7jiiFz9IrUR+ZbpGF/zOBAHt0IAmgDjKXz4t70 b1rohS+tMT5pxiURkUFx4LpZJdgSxkU9OmPFsQAAHhVjIqI268APBybTarBYpH5gqv oqzqE/ULKQZiW5h5BoreU3/pLKt5SZjZTiIM1+RQFKAFQuOgZYfQF8NVVZZW5MHk72 ZutpVxKJnjuUShfHWSEcpaSFZLGEQm6884LLZCuurtKK+IcS/L591YjXLPBjKUufGo ihjXGzjgvS2zQ== Received: (from danm@localhost) by prime.gushi.org (8.16.1/8.16.1/Submit) id 13EIgv3t002076; Wed, 14 Apr 2021 11:42:57 -0700 (PDT) (envelope-from danm) Date: Wed, 14 Apr 2021 11:42:55 -0700 (PDT) From: "Dan Mahoney (Gushi)" To: ports@freebsd.org Subject: rclint: two thoughts Message-ID: <2738d12-8b12-b873-cac2-ad6a3ced8ff@prime.gushi.org> X-OpenPGP-Key-ID: 0x624BB249 MIME-Version: 1.0 Content-Type: text/plain; format=flowed; charset=US-ASCII X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.2 (prime.gushi.org [0.0.0.0]); Wed, 14 Apr 2021 18:42:59 +0000 (UTC) X-Rspamd-Queue-Id: 4FLBDk3fDdz3qyR X-Spamd-Bar: ------ Authentication-Results: mx1.freebsd.org; dkim=pass header.d=gushi.org header.s=prime2014 header.b=cHBiY5ie; dmarc=pass (policy=none) header.from=gushi.org; spf=pass (mx1.freebsd.org: domain of danm@prime.gushi.org designates 2620:137:6000:10::142 as permitted sender) smtp.mailfrom=danm@prime.gushi.org X-Spamd-Result: default: False [-6.40 / 15.00]; R_SPF_ALLOW(-0.20)[+a]; TO_DN_NONE(0.00)[]; RCVD_DKIM_ARC_DNSWL_MED(-0.50)[]; RCVD_IN_DNSWL_MED(-0.20)[2620:137:6000:10::142:from]; DKIM_TRACE(0.00)[gushi.org:+]; DMARC_POLICY_ALLOW(-0.50)[gushi.org,none]; NEURAL_HAM_SHORT(-1.00)[-1.000]; FORGED_SENDER(0.30)[freebsd@gushi.org,danm@prime.gushi.org]; MIME_TRACE(0.00)[0:+]; RBL_DBL_DONT_QUERY_IPS(0.00)[2620:137:6000:10::142:from]; ASN(0.00)[asn:393507, ipnet:2620:137:6000::/44, country:US]; FROM_NEQ_ENVFROM(0.00)[freebsd@gushi.org,danm@prime.gushi.org]; ARC_NA(0.00)[]; NEURAL_HAM_MEDIUM(-1.00)[-1.000]; R_DKIM_ALLOW(-0.20)[gushi.org:s=prime2014]; FROM_HAS_DN(0.00)[]; DWL_DNSWL_MED(-2.00)[gushi.org:dkim]; TO_MATCH_ENVRCPT_ALL(0.00)[]; NEURAL_HAM_LONG(-1.00)[-1.000]; MIME_GOOD(-0.10)[text/plain]; PREVIOUSLY_DELIVERED(0.00)[ports@freebsd.org]; RCPT_COUNT_ONE(0.00)[1]; SPAMHAUS_ZRD(0.00)[2620:137:6000:10::142:from:127.0.2.255]; RCVD_COUNT_TWO(0.00)[2]; RCVD_TLS_ALL(0.00)[]; MAILMAN_DEST(0.00)[ports] X-BeenThere: freebsd-ports@freebsd.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Porting software to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 14 Apr 2021 18:43:04 -0000 First: With most of the move to git, portlint complains about a missing #$FreeBSD line, and one of the missing features of git is that it just doesn't support the usual tagging that cvs and svn gave us. Is this still a useful requirement? (For us, where we have rc scripts that will never be in mainline, adding a FreeBSD line feels especially dumb). Second: In trying to play with rclint both to validate the port I maintain, as well as some internal rc.d scripts we use at the day job, I'm finding *most* ports (and a good portion of base) don't pass rclint cleanly. Is this something worth pushing pr's (with patches) for, or would that just waste everyone's time? I've found some *really* old sed bugs (going back 20 years) in rc once, and it's clear they've lived there for a long, long time. I recognize that sometimes it's better to "if it ain't broke...don't fix it." -Dan -- --------Dan Mahoney-------- Techie, Sysadmin, WebGeek Gushi on efnet/undernet IRC FB: fb.com/DanielMahoneyIV LI: linkedin.com/in/gushi Site: http://www.gushi.org ---------------------------