Skip site navigation (1)Skip section navigation (2)
Date:      Wed, 16 Oct 1996 15:26:26 +0100 (MET)
From:      jhs@freebsd.org
To:        FreeBSD-gnats-submit@freebsd.org
Cc:        jhs@freebsd.org
Subject:   bin/1836: /usr/src/*/routed/table.c:	s/punt/abort/g
Message-ID:  <199610161426.PAA04311@vector.jhs.no_domain>
Resent-Message-ID: <199610181420.HAA25436@freefall.freebsd.org>

next in thread | raw e-mail | index | archive | help

>Number:         1836
>Category:       bin
>Synopsis:       Punt is american only, use abort.
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    freebsd-bugs
>State:          open
>Class:          change-request
>Submitter-Id:   current-users
>Arrival-Date:   Fri Oct 18 07:20:09 PDT 1996
>Last-Modified:
>Originator:     Julian Stacey jhs@freebsd.org
>Organization:
Julian Stacey jhs@freebsd.org
>Release:        FreeBSD 2.2-CURRENT i386
>Environment:
Current

>Description:

	Routed American not understandable in English.

	/usr/src/*/routed/table.c
	creates console messages like this:
	  Oct 16 13:10:46 vector routed[63]: punt RTM_LOSING without gateway
	
	That's not English (I am :-)
	`punt'
	        in the Penguin English Dictionary ('85-86) refers to a verb & noun: 
	        to punt (propel) a punt (flat bottom boat) on a river (or fen).
	`punt'
	        in American (according to Jordan, years ago, so forgive any inaccuracy):
	                to abandon or give up on something, or decline an invitation
	
	The message is obscure,
	a more globaly understandable word would be better, patch follows
	(feel free to choose a better American to global English translation
	than mine, I don't know what `punt' is except by hearsay,
	but `abort' is nearly as short :-)


>How-To-Repeat:

	Run current, drop modem slip link

>Fix:
	

=========
*** old/src/sbin/routed/table.c	Wed Oct 16 16:10:35 1996
--- new/src/sbin/routed/table.c	Wed Oct 16 16:11:37 1996
***************
*** 281,287 ****
  
  	NTOHL(dst);
  
! 	/* Punt non-contiguous subnet masks.
  	 *
  	 * (X & -X) contains a single bit if and only if X is a power of 2.
  	 * (X + (X & -X)) == 0 if and only if X is a power of 2.
--- 281,287 ----
  
  	NTOHL(dst);
  
! 	/* Abort non-contiguous subnet masks.
  	 *
  	 * (X & -X) contains a single bit if and only if X is a power of 2.
  	 * (X + (X & -X)) == 0 if and only if X is a power of 2.
***************
*** 831,844 ****
  	} else if (INFO_MASK(info) != 0) {
  		mask = ntohl(S_ADDR(INFO_MASK(info)));
  	} else {
! 		msglog("punt %s without mask",
  		       rtm_type_name(rtm->rtm_type));
  		return;
  	}
  
  	if (INFO_GATE(info) == 0
  	    || INFO_GATE(info)->sa_family != AF_INET) {
! 		msglog("punt %s without gateway",
  		       rtm_type_name(rtm->rtm_type));
  		return;
  	}
--- 831,844 ----
  	} else if (INFO_MASK(info) != 0) {
  		mask = ntohl(S_ADDR(INFO_MASK(info)));
  	} else {
! 		msglog("abort %s without mask",
  		       rtm_type_name(rtm->rtm_type));
  		return;
  	}
  
  	if (INFO_GATE(info) == 0
  	    || INFO_GATE(info)->sa_family != AF_INET) {
! 		msglog("abort %s without gateway",
  		       rtm_type_name(rtm->rtm_type));
  		return;
  	}
***************
*** 916,922 ****
  {
  	if (INFO_GATE(info) == 0
  	    || INFO_GATE(info)->sa_family != AF_INET) {
! 		msglog("punt %s without gateway",
  		       rtm_type_name(rtm->rtm_type));
  		return;
  	}
--- 916,922 ----
  {
  	if (INFO_GATE(info) == 0
  	    || INFO_GATE(info)->sa_family != AF_INET) {
! 		msglog("abort %s without gateway",
  		       rtm_type_name(rtm->rtm_type));
  		return;
  	}
=========
>Audit-Trail:
>Unformatted:



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?199610161426.PAA04311>