From owner-freebsd-bugs@freebsd.org  Wed Jun 14 14:20:46 2017
Return-Path: <owner-freebsd-bugs@freebsd.org>
Delivered-To: freebsd-bugs@mailman.ysv.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 by mailman.ysv.freebsd.org (Postfix) with ESMTP id ACAF1D8EDD3
 for <freebsd-bugs@mailman.ysv.freebsd.org>;
 Wed, 14 Jun 2017 14:20:46 +0000 (UTC)
 (envelope-from bugzilla-noreply@freebsd.org)
Received: from kenobi.freebsd.org (kenobi.freebsd.org
 [IPv6:2001:1900:2254:206a::16:76])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (Client did not present a certificate)
 by mx1.freebsd.org (Postfix) with ESMTPS id 9B36F652F5
 for <freebsd-bugs@FreeBSD.org>; Wed, 14 Jun 2017 14:20:46 +0000 (UTC)
 (envelope-from bugzilla-noreply@freebsd.org)
Received: from bugs.freebsd.org ([127.0.1.118])
 by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id v5EEKkr9060880
 for <freebsd-bugs@FreeBSD.org>; Wed, 14 Jun 2017 14:20:46 GMT
 (envelope-from bugzilla-noreply@freebsd.org)
From: bugzilla-noreply@freebsd.org
To: freebsd-bugs@FreeBSD.org
Subject: [Bug 219986] [mly] sys/dev/mly/mly.c: a sleep-under-mutex bug in
 mly_user_command
Date: Wed, 14 Jun 2017 14:20:46 +0000
X-Bugzilla-Reason: AssignedTo
X-Bugzilla-Type: new
X-Bugzilla-Watch-Reason: None
X-Bugzilla-Product: Base System
X-Bugzilla-Component: kern
X-Bugzilla-Version: 11.0-RELEASE
X-Bugzilla-Keywords: 
X-Bugzilla-Severity: Affects Only Me
X-Bugzilla-Who: baijiaju1990@163.com
X-Bugzilla-Status: New
X-Bugzilla-Resolution: 
X-Bugzilla-Priority: ---
X-Bugzilla-Assigned-To: freebsd-bugs@FreeBSD.org
X-Bugzilla-Flags: 
X-Bugzilla-Changed-Fields: bug_id short_desc product version rep_platform
 op_sys bug_status bug_severity priority component assigned_to reporter
Message-ID: <bug-219986-8@https.bugs.freebsd.org/bugzilla/>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/
Auto-Submitted: auto-generated
MIME-Version: 1.0
X-BeenThere: freebsd-bugs@freebsd.org
X-Mailman-Version: 2.1.23
Precedence: list
List-Id: Bug reports <freebsd-bugs.freebsd.org>
List-Unsubscribe: <https://lists.freebsd.org/mailman/options/freebsd-bugs>,
 <mailto:freebsd-bugs-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-bugs/>
List-Post: <mailto:freebsd-bugs@freebsd.org>
List-Help: <mailto:freebsd-bugs-request@freebsd.org?subject=help>
List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/freebsd-bugs>,
 <mailto:freebsd-bugs-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Wed, 14 Jun 2017 14:20:46 -0000

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D219986

            Bug ID: 219986
           Summary: [mly] sys/dev/mly/mly.c: a sleep-under-mutex bug in
                    mly_user_command
           Product: Base System
           Version: 11.0-RELEASE
          Hardware: i386
                OS: Any
            Status: New
          Severity: Affects Only Me
          Priority: ---
         Component: kern
          Assignee: freebsd-bugs@FreeBSD.org
          Reporter: baijiaju1990@163.com

The mly driver may sleep under a mutex, and the function call path in file
"sys/dev/mly/mly.c" in FreeBSD 11.0 is:
mly_user_command [line 2925: acquire the mutex]
  mly_start [line 2926]
    mly_map_command [line 1489]
      bus_dmamap_load_ccb(BUS_DMA_WAITOK) [line 1880] --> may sleep
      bus_dmamap_load(BUS_DMA_WAITOK) [line 1883] --> may sleep

The possible fix of this bug is to set last parameter in bus_dmamap_load_ccb
and bus_dmamap_load to "BUS_DMA_NOWAIT".

This bug is found by a static analysis tool written by myself, and it is
checked by my review of the FreeBSD code.

By the way, I am a freshman in developing FreeBSD drivers, and I am willing=
 to
submit a patch to fix this bug. But I do not know how to write and submit a
patch, and where to submit, so I am looking forward to useful advice :)

Jia-Ju Bai

--=20
You are receiving this mail because:
You are the assignee for the bug.=