Date: Thu, 08 Feb 2001 10:38:30 -0500 (EST) From: Mike Heffner <mheffner@vt.edu> To: Warner Losh <imp@harmony.village.org> Cc: FreeBSD-audit <FreeBSD-audit@FreeBSD.ORG> Subject: Re: lam(1) patch Message-ID: <XFMail.20010208103830.mheffner@vt.edu> In-Reply-To: <200102072318.f17NIj996425@harmony.village.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On 07-Feb-2001 Warner Losh wrote: | In message <XFMail.20010207180049.mheffner@vt.edu> Mike Heffner writes: |: | Also available from: |: | http://filebox.vt.edu/users/mheffner/patches/lam.patch |: Any objections to me committing this? [ snip ] |: Also, should I follow it up with a de-__P() patch? | | Yes. So long as you make all the old K&R style decls into ANSI ones | at the same time. | Ok, after screwing up the last style patch, here is a the latest version I've put together. I think this fulfills all the style(9) requirements and everyones comments from the last patch (accept keeping the K&R style). Spaces after function names were removed and the char** has been restored to char *[]. Index: lam.c =================================================================== RCS file: /home/ncvs/src/usr.bin/lam/lam.c,v retrieving revision 1.6 diff -u -r1.6 lam.c --- lam.c 2001/02/08 05:58:55 1.6 +++ lam.c 2001/02/08 15:28:50 @@ -73,13 +73,13 @@ char line[BIGBUFSIZ]; char *linep; -char *gatherline (struct openfile *); -void getargs (char **); -char *pad (struct openfile *); -static void usage (void); +char *gatherline(struct openfile *); +void getargs(char *[]); +char *pad(struct openfile *); +static void usage(void); int -main(int argc, char **argv) +main(int argc, char *argv[]) { struct openfile *ip; @@ -100,7 +100,7 @@ } void -getargs(char **av) +getargs(char *av[]) { struct openfile *ip = input; char *p, *c; (also at: http://filebox.vt.edu/users/mheffner/patches/lam.style.patch) -- Mike Heffner <mheffner@vt.edu> Blacksburg, VA <mikeh@FreeBSD.org> http://filebox.vt.edu/users/mheffner To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-audit" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?XFMail.20010208103830.mheffner>