From owner-svn-ports-all@freebsd.org Thu Apr 27 06:24:59 2017 Return-Path: Delivered-To: svn-ports-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 745CFD527D5; Thu, 27 Apr 2017 06:24:59 +0000 (UTC) (envelope-from mat@FreeBSD.org) Received: from prod2.absolight.net (prod2.absolight.net [79.143.243.136]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "plouf.absolight.net", Issuer "CAcert Class 3 Root" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 11D781715; Thu, 27 Apr 2017 06:24:58 +0000 (UTC) (envelope-from mat@FreeBSD.org) Received: from prod2.absolight.net (localhost [127.0.0.1]) by prod2.absolight.net (Postfix) with ESMTP id E41FCBDC9B; Thu, 27 Apr 2017 08:24:55 +0200 (CEST) Received: from atuin.in.mat.cc (atuin.in.mat.cc [79.143.241.205]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client did not present a certificate) by prod2.absolight.net (Postfix) with ESMTPSA id 8DBDEBDCB8; Thu, 27 Apr 2017 08:24:55 +0200 (CEST) Subject: Re: svn commit: r439421 - in head/www/nginx: . files To: "Sergey A. Osokin" , Mathieu Arnold Cc: ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org References: <201704252318.v3PNI9Io032993@repo.freebsd.org> <20170426165333.GC18747@FreeBSD.org> From: Mathieu Arnold Organization: Absolight / The FreeBSD Foundation Message-ID: <1426aa14-e30f-bb33-6e76-5fdfdd222e74@FreeBSD.org> Date: Thu, 27 Apr 2017 08:24:55 +0200 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.11; rv:52.0) Gecko/20100101 Thunderbird/52.0.1 MIME-Version: 1.0 In-Reply-To: <20170426165333.GC18747@FreeBSD.org> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Content-Language: fr X-BeenThere: svn-ports-all@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: SVN commit messages for the ports tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 27 Apr 2017 06:24:59 -0000 Le 26/04/2017 =C3=A0 18:53, Sergey A. Osokin a =C3=A9crit : > On Wed, Apr 26, 2017 at 06:18:44PM +0200, Mathieu Arnold wrote: >> Le 26/04/2017 ?? 01:18, Sergey A. Osokin a ??crit : >>> Author: osa >>> Date: Tue Apr 25 23:18:09 2017 >>> New Revision: 439421 >>> URL: https://svnweb.freebsd.org/changeset/ports/439421 >>> >>> Log: >>> Upgrade from 1.10.3 to 1.12.0. >>> =20 >>> ChangeLog: http://nginx.org/en/CHANGES-1.12 >>> =20 >>> Remove IPV6 knob, IPv6 now compiled-in automatically if support is = found. >> This still feels like a very bad idea. > Could you please explain what exactly is very bad here? > =20 We had that talk like a week or two ago. It means that if the package builder support IPv6 it will not work on a box without it, and if the package builder does not support IPv6, a box with IPv6 will not be able to use nginx with IPv6. >>> Also, remove third-party modules: >>> o) udplog >>> o) statsd >>> =20 >>> Enable third_party mod_zip module back by changing upstream. >>> =20 >> I think this is what breaks the build: >> >> https://pkg.absolight.fr/data/11amd64-pkgng-default/20170426T181224Z/l= ogs/errors/nginx-1.12.0,2.log >> >> cc -c -I/usr/local/include/luajit-2.0 -O2 -pipe -DLIBICONV_PLUG -fsta= ck-protector -fno-strict-aliasing -I /usr/local/include -DNDK_SET_VAR -Wn= o-write-strings -DNDK_SET_VAR -I src/core -I src/event -I src/event/mo= dules -I src/os/unix -I /wrkdirs/usr/ports/www/nginx/work/nginx-push-st= ream-module-0.5.1/src -I /wrkdirs/usr/ports/www/nginx/work/nginx-push-st= ream-module-0.5.1/include -I /wrkdirs/usr/ports/www/nginx/work/ngx_devel= _kit-0.3.0/objs -I objs/addon/ndk -I /wrkdirs/usr/ports/www/nginx/work/= lua-nginx-module-0.10.8/src/api -I /usr/local/include/libxml2 -I /usr/l= ocal/include -I objs -I src/http -I src/http/modules -I src/http/v2 = -I src/http/modules/perl -I /wrkdirs/usr/ports/www/nginx/work/nchan-0.99= =2E16/src -I /wrkdirs/usr/ports/www/nginx/work/ngx_devel_kit-0.3.0/src = -I /wrkdirs/usr/ports/www/nginx/work/ngx_devel_kit-0.3.0/src -I /wrkdirs= /usr/ports/www/nginx/work/ngx_devel_kit-0.3.0/objs -I objs/addon/ndk -I= /usr/local/include/luajit-2.0 -I /wrkdirs/usr/ports/www/nginx/work/njs-= 753ebe6/nginx/../nxt -I /wrkdirs/usr/ports/www/nginx/work/njs-753ebe6/ng= inx/../njs -I src/mail -I src/stream -I /wrkdirs/usr/ports/www/nginx/w= ork/njs-753ebe6/nginx/../nxt -I /wrkdirs/usr/ports/www/nginx/work/njs-75= 3ebe6/nginx/../njs -o objs/addon/mod_zip-74ef235/ngx_http_zip_module.o = /wrkdirs/usr/ports/www/nginx/work/mod_zip-74ef235/ngx_http_zip_module.c >> /wrkdirs/usr/ports/www/nginx/work/mod_zip-74ef235/ngx_http_zip_module.= c:74:4: error: no member named 'charset' in '' >> offsetof(ngx_http_zip_conf_t, charset), >> ^ ~~~~~~~ >> /usr/include/stddef.h:65:32: note: expanded from macro 'offsetof' >> #define offsetof(type, member) __offsetof(type, member) >> ^ ~~~~~~ >> /usr/include/sys/cdefs.h:477:34: note: expanded from macro '__offsetof= ' >> #define __offsetof(type, field) __builtin_offsetof(type, field) >> ^ ~~~~~ >> 1 error generated. >> *** Error code 1 > Need an explanation here why third-party mod_zip module has been enable= d, cause by > default all third-party modules should be switched off. Because it was enabled by someone, me, for instance ? --=20 Mathieu Arnold