From owner-cvs-all@FreeBSD.ORG Thu Aug 28 21:51:55 2008 Return-Path: Delivered-To: cvs-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 8F137106568D; Thu, 28 Aug 2008 21:51:55 +0000 (UTC) (envelope-from keramida@freebsd.org) Received: from igloo.linux.gr (igloo.linux.gr [62.1.205.36]) by mx1.freebsd.org (Postfix) with ESMTP id 00B918FC18; Thu, 28 Aug 2008 21:51:54 +0000 (UTC) (envelope-from keramida@freebsd.org) Received: from kobe.laptop (athedsl-148466.home.otenet.gr [85.75.251.145]) (authenticated bits=128) by igloo.linux.gr (8.14.3/8.14.3/Debian-5) with ESMTP id m7SLpjaG002540 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NOT); Fri, 29 Aug 2008 00:51:51 +0300 Received: from kobe.laptop (kobe.laptop [127.0.0.1]) by kobe.laptop (8.14.3/8.14.3) with ESMTP id m7SLpeV6015391; Fri, 29 Aug 2008 00:51:40 +0300 (EEST) (envelope-from keramida@freebsd.org) Received: (from keramida@localhost) by kobe.laptop (8.14.3/8.14.3/Submit) id m7SLpdXq015373; Fri, 29 Aug 2008 00:51:39 +0300 (EEST) (envelope-from keramida@freebsd.org) From: Giorgos Keramidas To: Randall Stewart References: <200808282031.m7SKVUdD076580@repoman.freebsd.org> Date: Fri, 29 Aug 2008 00:51:39 +0300 In-Reply-To: <200808282031.m7SKVUdD076580@repoman.freebsd.org> (Randall Stewart's message of "Thu, 28 Aug 2008 20:31:24 +0000 (UTC)") Message-ID: <87tzd4n6z8.fsf@kobe.laptop> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.0.60 (berkeley-unix) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-MailScanner-ID: m7SLpjaG002540 X-Hellug-MailScanner: Found to be clean X-Hellug-MailScanner-SpamCheck: not spam, SpamAssassin (not cached, score=-4.399, required 5, autolearn=not spam, ALL_TRUSTED -1.80, BAYES_00 -2.60) X-Hellug-MailScanner-From: keramida@freebsd.org X-Spam-Status: No Cc: cvs-src@freebsd.org, src-committers@freebsd.org, cvs-all@freebsd.org Subject: Re: cvs commit: src/sys/netinet sctp_timer.c sctp_timer.h X-BeenThere: cvs-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the entire tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 28 Aug 2008 21:51:55 -0000 On Thu, 28 Aug 2008 20:31:24 +0000 (UTC), Randall Stewart wrote: > rrs 2008-08-28 20:31:24 UTC > > FreeBSD src repository > > Modified files: > sys/netinet sctp_timer.c sctp_timer.h > Log: > SVN rev 182405 on 2008-08-28 20:31:24Z by rrs > > ok, non static the function and put in the .h so > when we do INVARANT compile the compiler will not > dis the function that is not used. Hmm maybe I should have > made it ifndef INVARIANTs.. gcc should be smart enough to throw away the non-static function if SCTP is built into the kernel (and not as a module) *and* there are no external references from other parts of the source. So this should work fine. The ifndef INVARIANTS version is probably something like the second patch I sent earlier, also at http://people.freebsd.org/~keramida/diff/sctp-timer-20080828-02.patch but I didn't really 'like' having a static function inside a large #ifndef INVARIANTS block... Thanks for fixing this so fast :-)