From owner-freebsd-current Fri Aug 16 16:57:57 1996 Return-Path: owner-current Received: (from root@localhost) by freefall.freebsd.org (8.7.5/8.7.3) id QAA00911 for current-outgoing; Fri, 16 Aug 1996 16:57:57 -0700 (PDT) Received: from godzilla.zeta.org.au (godzilla.zeta.org.au [203.2.228.19]) by freefall.freebsd.org (8.7.5/8.7.3) with SMTP id QAA00899 for ; Fri, 16 Aug 1996 16:57:46 -0700 (PDT) Received: (from bde@localhost) by godzilla.zeta.org.au (8.6.12/8.6.9) id JAA07932; Sat, 17 Aug 1996 09:52:22 +1000 Date: Sat, 17 Aug 1996 09:52:22 +1000 From: Bruce Evans Message-Id: <199608162352.JAA07932@godzilla.zeta.org.au> To: imb@asstdc.com.au, julian@whistle.com Subject: Re: patch for consideration .. multi-block IDE Cc: current@FreeBSD.org Sender: owner-current@FreeBSD.org X-Loop: FreeBSD.org Precedence: bulk >What happenned to this? Nothing. >I notice that it's not in -current.. >Bruce, did you veto this or something? I just pointed out all the bugs in the new and old versions. I'll leave it to someone who actually uses multi-mode to fix it. Bugs: 1. No check that the WDCC_SET_MULTI command actually works. Affects all versions. 2. du->dk_multi is never set to anything other than 1, so multi-mode is never used. Affects current version. 3. The proposed patch sets du->dk_multi too early, so the boot message is wrong if multi-mode isn't configured or setting it fails. It isn't easy to print the final setting in the boot message since the final setting isn't decided at attach time. Bruce >> *** /sys/i386/isa/wd.c.orig Sun Jul 28 06:52:04 1996 >> --- /sys/i386/isa/wd.c Wed Aug 7 18:59:08 1996 >> *************** >> *** 1665,1670 **** >> --- 1665,1671 ---- >> du->dk_dd.d_type = DTYPE_ESDI; >> du->dk_dd.d_subtype |= DSTYPE_GEOMETRY; >> #endif >> + du->dk_multi = wp->wdp_nsecperint & 0xff; >> >> return (0); >> }