From owner-svn-ports-head@freebsd.org Wed Feb 27 15:23:08 2019 Return-Path: Delivered-To: svn-ports-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 16293151F80A; Wed, 27 Feb 2019 15:23:08 +0000 (UTC) (envelope-from cy.schubert@cschubert.com) Received: from smtp-out-no.shaw.ca (smtp-out-no.shaw.ca [64.59.134.13]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "Client", Issuer "CA" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 34F2382CA5; Wed, 27 Feb 2019 15:23:06 +0000 (UTC) (envelope-from cy.schubert@cschubert.com) Received: from spqr.komquats.com ([70.67.125.17]) by shaw.ca with ESMTPA id z130g2zxMybAdz131gYkNF; Wed, 27 Feb 2019 08:23:04 -0700 X-Authority-Analysis: v=2.3 cv=WqRVzuXv c=1 sm=1 tr=0 a=VFtTW3WuZNDh6VkGe7fA3g==:117 a=VFtTW3WuZNDh6VkGe7fA3g==:17 a=IkcTkHD0fZMA:10 a=CFTnQlWoA9kA:10 a=6I5d2MoRAAAA:8 a=YxBL1-UpAAAA:8 a=bEzOqISF9EAFJj5-67EA:9 a=QEXdDO2ut3YA:10 a=IjZwj45LgO3ly-622nXo:22 a=Ia-lj3WSrqcvXOmTRaiG:22 Received: from android-68f84e02b5988183.esitwifi.local (S0106788a207e2972.gv.shawcable.net [70.66.154.233]) by spqr.komquats.com (Postfix) with ESMTPSA id 0E342211; Wed, 27 Feb 2019 07:23:02 -0800 (PST) Date: Wed, 27 Feb 2019 06:53:10 -0800 User-Agent: K-9 Mail for Android In-Reply-To: <20190227131242.GA6386@FreeBSD.org> References: <201902271255.x1RCtIJs066388@repo.freebsd.org> <20190227131242.GA6386@FreeBSD.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Subject: Re: svn commit: r494049 - in head/devel/imake: . files To: Alexey Dokuchaev ,Niclas Zeising CC: ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org From: Cy Schubert Message-ID: X-CMAE-Envelope: MS4wfG/G3Gyssvfnquss1ZFk1JibHEWxdeeobUAqu3yrXCdV/2rP6qOWOzLxoA6BwthVjcYXhw7QweqAfQwFyb8iXxcw/bPtVNve70s1F758KsCKFRwtq61v FqCKfLOb0aBXJAPi472olC5F0KAOsxIDur3cGiE0TisuZnS4ThJ5eMgxSgHGg+U5RRypgV2CNWTTQDewV3gUW6q3GabEdwbN8sBjIFo4Ib8psMn3C1Y5Uuxg yX5FgWVjYn2ri7xWzTwn/Km0RSOZFnUNGlqxWCkyXJ6Ru+b9l4Kak/peXoM4liMj7jju9ljeCz7Z3wfeljsQyBBF9JU7is/5LLmiLobIvCk= X-Rspamd-Queue-Id: 34F2382CA5 X-Spamd-Bar: ------ Authentication-Results: mx1.freebsd.org X-Spamd-Result: default: False [-6.96 / 15.00]; NEURAL_HAM_MEDIUM(-1.00)[-1.000,0]; NEURAL_HAM_SHORT(-0.96)[-0.963,0]; REPLY(-4.00)[]; NEURAL_HAM_LONG(-1.00)[-1.000,0] X-BeenThere: svn-ports-head@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: SVN commit messages for the ports tree for head List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 27 Feb 2019 15:23:08 -0000 Making unrelated changes in the same commit, even when documented, makes pa= rsing of the patch necessary for those who might need to analyze a patch mo= nths after the fact=2E Though painful either way, this is more critical in = src than ports=2E On February 27, 2019 5:12:42 AM PST, Alexey Dokuchaev wrote: >On Wed, Feb 27, 2019 at 12:55:18PM +0000, Niclas Zeising wrote: >> New Revision: 494049 >> URL: https://svnweb=2Efreebsd=2Eorg/changeset/ports/494049 >>=20 >> Log: >> devel/imake Add LICENSE > >Could your please not include unrealated changes in the same commit? >Now you've broken svn blaming on these patches, as the real history >would be masked with this "add LICENSE" nonsense which has nothing >to do with them=2E > >=2E/danfe > >> Modified: head/devel/imake/files/patch-imake=2Ec >> >=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D >> --- head/devel/imake/files/patch-imake=2Ec Wed Feb 27 12:06:57 >2019 (r494048) >> +++ head/devel/imake/files/patch-imake=2Ec Wed Feb 27 12:55:18 >2019 (r494049) >> @@ -1,6 +1,6 @@ >> ---- imake=2Ec=2Eorig 2013-07-23 06:53:04=2E000000000 +0200 >> -+++ imake=2Ec 2013-08-31 14:57:48=2E000000000 +0200 >> -@@ -531,6 +531,14 @@ >> +--- imake=2Ec=2Eorig 2013-08-17 10:11:50 UTC >> ++++ imake=2Ec >> +@@ -531,6 +531,14 @@ init(void) >> AddCppArg(p); >> } >> } >> @@ -15,7 +15,7 @@ >> if ((p =3D getenv("IMAKECPP"))) >> cpp =3D p; >> if ((p =3D getenv("IMAKEMAKE"))) >> -@@ -1142,29 +1150,17 @@ >> +@@ -1142,29 +1150,17 @@ get_binary_format(FILE *inFile) >> int mib[2]; >> size_t len; >> int osrel =3D 0; >>=20 >> Modified: head/devel/imake/files/patch-imakemdep=2Eh >> >=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D >> --- head/devel/imake/files/patch-imakemdep=2Eh Wed Feb 27 12:06:57 >2019 (r494048) >> +++ head/devel/imake/files/patch-imakemdep=2Eh Wed Feb 27 12:55:18 >2019 (r494049) >> @@ -1,6 +1,6 @@ >> ---- =2E/imakemdep=2Eh=2Eorig 2012-03-08 06:47:32=2E000000000 +0100 >> -+++ =2E/imakemdep=2Eh 2013-06-12 20:22:52=2E058999526 +0200 >> -@@ -380,7 +383,7 @@ >> +--- imakemdep=2Eh=2Eorig 2013-08-17 10:11:06 UTC >> ++++ imakemdep=2Eh >> +@@ -365,7 +365,7 @@ const char *cpp_argv[ARGUMENTS] =3D { >> defined(__GNUC__) || defined(__GLIBC__) >> # ifdef __i386__ >> "-D__i386__", >>=20 --=20 Pardon the typos and autocorrect, small keyboard in use=2E Cheers, Cy Schubert FreeBSD UNIX: Web: http://www=2EFreeBSD=2Eorg The need of the many outweighs the greed of the few=2E