From owner-svn-src-head@freebsd.org Tue May 28 17:32:48 2019 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id DE44F15A6A57; Tue, 28 May 2019 17:32:47 +0000 (UTC) (envelope-from br@bsdpad.com) Received: from sc1.bsdpad.com (sc1.bsdpad.com [163.172.212.18]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) server-signature RSA-PSS (4096 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id D00338A256; Tue, 28 May 2019 17:32:45 +0000 (UTC) (envelope-from br@bsdpad.com) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=bsdpad.com; s=20190317; h=Subject:To:From; bh=zpSHr6YdWstlIlDA1f+x2QYZPY8k+fI4HcuWIKi4Ziw=; b=F3ILVqDkgdiWoqZ64FRLQs9Cvf HYYn7zmtAUnHu7aKuCCV6SuPMrz1K7zQxEiqNbNWc0EJ/r9SIEs/0v4g9327jmIvByXt7QdG//y1T sbepV2VigOO9NGtbGv+Ue/spUiDpBBYK+84NtJmB2jdjk5FtSXh6eEbCuUGrqlBJdLwPtoSs66uV8 jSXmFacpDmExyVVScABJobRibx+UpD5KUUOqT1Sg0ovhoFnXjp1A7WO9OaHjU2Ty7XjTmW/F7zMCX E0qsX3MfzknjP6ItHcTdBMKpDKZlxUA4saZYdRcj+GgvFNCmsQgA0rnJJFWdcJ2CWs9v5fULhsK/+ gniGi/9g==; Received: from localhost ([127.0.0.1] helo=bsdpad.com) by sc1.bsdpad.com with smtp (Exim 4.91 (FreeBSD)) (envelope-from ) id 1hVfwk-000Oco-Qs; Tue, 28 May 2019 18:31:34 +0100 Received: by bsdpad.com (nbSMTP-1.00) for uid 1001 br@bsdpad.com; Tue, 28 May 2019 18:31:34 +0100 (BST) Date: Tue, 28 May 2019 18:31:34 +0100 From: Ruslan Bukin To: Emmanuel Vadot Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r347930 - head/sys/dev/pci Message-ID: <20190528173134.GA94573@bsdpad.com> References: <201905171705.x4HH5HDR059483@repo.freebsd.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <201905171705.x4HH5HDR059483@repo.freebsd.org> User-Agent: Mutt/1.11.2 (2019-01-07) X-Rspamd-Queue-Id: D00338A256 X-Spamd-Bar: ----- Authentication-Results: mx1.freebsd.org; dkim=pass header.d=bsdpad.com header.s=20190317 header.b=F3ILVqDk; spf=pass (mx1.freebsd.org: domain of br@bsdpad.com designates 163.172.212.18 as permitted sender) smtp.mailfrom=br@bsdpad.com X-Spamd-Result: default: False [-5.94 / 15.00]; ARC_NA(0.00)[]; NEURAL_HAM_MEDIUM(-1.00)[-1.000,0]; R_DKIM_ALLOW(-0.20)[bsdpad.com:s=20190317]; FROM_HAS_DN(0.00)[]; RCPT_COUNT_THREE(0.00)[4]; R_SPF_ALLOW(-0.20)[+mx]; TO_MATCH_ENVRCPT_ALL(0.00)[]; MIME_GOOD(-0.10)[text/plain]; DMARC_NA(0.00)[freebsd.org]; NEURAL_HAM_LONG(-1.00)[-1.000,0]; TO_DN_SOME(0.00)[]; RCVD_COUNT_THREE(0.00)[3]; IP_SCORE(-2.83)[ip: (-9.26), ipnet: 163.172.208.0/20(-4.63), asn: 12876(-0.24), country: FR(-0.01)]; DKIM_TRACE(0.00)[bsdpad.com:+]; MX_GOOD(-0.01)[sc1.bsdpad.com]; NEURAL_HAM_SHORT(-0.90)[-0.899,0]; FORGED_SENDER(0.30)[br@freebsd.org,br@bsdpad.com]; MIME_TRACE(0.00)[0:+]; RCVD_TLS_LAST(0.00)[]; ASN(0.00)[asn:12876, ipnet:163.172.208.0/20, country:FR]; FROM_NEQ_ENVFROM(0.00)[br@freebsd.org,br@bsdpad.com] X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 28 May 2019 17:32:48 -0000 On Fri, May 17, 2019 at 05:05:17PM +0000, Emmanuel Vadot wrote: > Author: manu > Date: Fri May 17 17:05:16 2019 > New Revision: 347930 > URL: https://svnweb.freebsd.org/changeset/base/347930 > > Log: > pci: ecam: Correctly parse memory and IO region > > When activating a resource do not compare the resource id to the adress. > Treat IO region as MEMORY region too. > > Submitted by: Tuan Phan (Original Version) > Sponsored by: Ampere Computing, LLC > Differential Revision: https://reviews.freebsd.org/D20214 > > Modified: > head/sys/dev/pci/pci_host_generic.c > head/sys/dev/pci/pci_host_generic_acpi.c > > Modified: head/sys/dev/pci/pci_host_generic_acpi.c > ============================================================================== > --- head/sys/dev/pci/pci_host_generic_acpi.c Fri May 17 17:04:01 2019 (r347929) > +++ head/sys/dev/pci/pci_host_generic_acpi.c Fri May 17 17:05:16 2019 (r347930) > @@ -293,7 +291,7 @@ pci_host_generic_acpi_attach(device_t dev) > continue; /* empty range element */ > if (sc->base.ranges[tuple].flags & FLAG_MEM) { > error = rman_manage_region(&sc->base.mem_rman, > - phys_base, phys_base + size - 1); > + pci_base, pci_base + size - 1); > } else if (sc->base.ranges[tuple].flags & FLAG_IO) { > error = rman_manage_region(&sc->base.io_rman, > pci_base + PCI_IO_WINDOW_OFFSET, > Don't we need to make a similar change to pci_host_generic_fdt.c ? Ruslan