Skip site navigation (1)Skip section navigation (2)
Date:      Tue, 9 Aug 2011 08:11:27 +0000 (UTC)
From:      Alexander Motin <mav@FreeBSD.org>
To:        src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org
Subject:   svn commit: r224728 - head/sys/dev/usb
Message-ID:  <201108090811.p798BRgS083513@svn.freebsd.org>

next in thread | raw e-mail | index | archive | help
Author: mav
Date: Tue Aug  9 08:11:26 2011
New Revision: 224728
URL: http://svn.freebsd.org/changeset/base/224728

Log:
  Do not block zero report ID. It is correct value for devices with single
  ID. This fixes USB_SET_IMMED call (synchronous operation) of the uhid(4)
  driver on devices with single report ID.
  
  Reviewed by:	hselasky
  Approved by:	re (kib)
  MFC after:	1 week

Modified:
  head/sys/dev/usb/usb_request.c

Modified: head/sys/dev/usb/usb_request.c
==============================================================================
--- head/sys/dev/usb/usb_request.c	Tue Aug  9 08:09:32 2011	(r224727)
+++ head/sys/dev/usb/usb_request.c	Tue Aug  9 08:11:26 2011	(r224728)
@@ -1769,7 +1769,7 @@ usbd_req_get_report(struct usb_device *u
 	struct usb_interface *iface = usbd_get_iface(udev, iface_index);
 	struct usb_device_request req;
 
-	if ((iface == NULL) || (iface->idesc == NULL) || (id == 0)) {
+	if ((iface == NULL) || (iface->idesc == NULL)) {
 		return (USB_ERR_INVAL);
 	}
 	DPRINTFN(5, "len=%d\n", len);



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201108090811.p798BRgS083513>