Date: Sun, 31 Jan 2010 15:56:06 +0100 From: Rainer Hurling <rhurlin@gwdg.de> To: "b. f." <bf1783@googlemail.com> Cc: freebsd-ports@freebsd.org Subject: Re: Need help with new port math/ggobi Message-ID: <4B659A06.7030309@gwdg.de> In-Reply-To: <d873d5be1001310636r4bf2f6fbgbbd24eb32c85adb0@mail.gmail.com> References: <d873d5be1001280853l614f18bbi9ef565a39693a2d6@mail.gmail.com> <4B61EB16.9090205@gwdg.de> <4B6580B7.5040804@gwdg.de> <d873d5be1001310636r4bf2f6fbgbbd24eb32c85adb0@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On 31.01.2010 15:36 (UTC+1), b. f. wrote:
> On 1/31/10, Rainer Hurling<rhurlin@gwdg.de> wrote:
>> I have a last question before I will do send-pr for my new port math/ggobi.
>>
>> The original program wants to install 'ggobi.pc' under
>>
>> /usr/local/lib/pkgconfig/
>>
>> instead of
>>
>> /usr/local/libdata/pkgconfig/
>>
>> I wrote a small patch in Makefile to change the location:
>>
>> post-patch:
>> @${REINPLACE_CMD} -e
>> 's|$$(libdir)/pkgconfig|${PREFIX}/libdata/pkgconfig|' \
>> ${WRKSRC}/Makefile.am \
>> ${WRKSRC}/Makefile.in
>>
>> Do you think this replacement is save enough if someone wants to install
>> in another place?
>
> At first glance, it looks okay, although if you are not remaking
> Makefile.in, you could probably just patch Makefile.in, and ignore
> Makefile.am. But since you are already using some components of
> Gnome, you could instead just add 'gnomehack' to USE_GNOME, which
> already has some boilerplate code to do this, rather than adding your
> own custom post-patch target. Also, I think that you can use @dirrm
> instead of @dirrmtry for etc/xdg/ggobi (although not for etc/xdg).
USE_GNOME gnomehack:
Whow, I was not aware of it. Yes, it also takes care for the right place
to install ggobi.pc.
@dirrmtry etc/xdg/ggobi:
This is because we can not be sure if a customized ggobirc file should
remain for the next install or update.
Many thanks again for your help. I think it is time to prepare a PR now :-)
Rainer
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?4B659A06.7030309>