From owner-freebsd-rc@FreeBSD.ORG Mon Apr 14 01:52:02 2014 Return-Path: Delivered-To: rc@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 4D92D304; Mon, 14 Apr 2014 01:52:02 +0000 (UTC) Received: from mx1.fisglobal.com (mx1.fisglobal.com [199.200.24.190]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client CN "mx1.fisglobal.com", Issuer "VeriSign Class 3 Secure Server CA - G3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 105881DE6; Mon, 14 Apr 2014 01:52:01 +0000 (UTC) Received: from smarthost.fisglobal.com ([10.132.206.193]) by ltcfislmsgpa06.fnfis.com (8.14.5/8.14.5) with ESMTP id s3E1pxn6031160 (version=TLSv1/SSLv3 cipher=AES128-SHA bits=128 verify=NOT); Sun, 13 Apr 2014 20:51:59 -0500 Received: from THEMADHATTER (10.242.181.54) by smarthost.fisglobal.com (10.132.206.193) with Microsoft SMTP Server id 14.3.174.1; Sun, 13 Apr 2014 20:51:57 -0500 From: Sender: Devin Teske To: "'Jason Hellenthal'" , References: <04c901cf4c5d$a6a4a030$f3ede090$@FreeBSD.org> <0EBE3981-DC85-414D-85B8-7638F172040A@dataix.net> <04f701cf4c85$d1929680$74b7c380$@FreeBSD.org> <20140331.121757.1100840815853109946.hrs@allbsd.org> <069f01cf4d14$0ff03980$2fd0ac80$@FreeBSD.org> <0d7c01cf52b3$05a02a40$10e07ec0$@FreeBSD.org> <9013F8C6-E259-4FA2-800D-B5A43828F411@dataix.net> In-Reply-To: <9013F8C6-E259-4FA2-800D-B5A43828F411@dataix.net> Subject: RE: network.subr _aliasN handling Date: Sun, 13 Apr 2014 18:51:42 -0700 Message-ID: <008e01cf5784$174b63b0$45e22b10$@FreeBSD.org> MIME-Version: 1.0 X-Mailer: Microsoft Outlook 15.0 Thread-Index: AQLl7DYKykKh8p6TvLmmwe5q3zMB9AI3LylbArF10lEChFGO0gGefDWYAWFgvvAB2s3RBJiA8nmQ Content-Language: en-us X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:5.11.96, 1.0.14, 0.0.0000 definitions=2014-04-12_01:2014-04-11,2014-04-12,1970-01-01 signatures=0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-Content-Filtered-By: Mailman/MimeDel 2.1.17 Cc: rc@FreeBSD.org, dteske@FreeBSD.org X-BeenThere: freebsd-rc@freebsd.org X-Mailman-Version: 2.1.17 Precedence: list List-Id: "Discussion related to /etc/rc.d design and implementation." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 14 Apr 2014 01:52:02 -0000 Merged. stable/10: http://svnweb.freebsd.org/base?view=3Drevision &revision=3D264438 stable/9: http://svnweb.freebsd.org/base?view=3Drevision &revision=3D264439 --=20 Devin =20 From: Jason Hellenthal [mailto:jhellenthal@dataix.net]=20 Sent: Monday, April 7, 2014 4:08 PM To: Cc: ; Hiroki Sato; ; Subject: Re: network.subr _aliasN handling =20 Looking forward to next week. Thanks again Devin. Nice work and well apprec= iated. --=20 Jason Hellenthal Voice: 95.30.17.6/616 JJH48-ARIN On Apr 7, 2014, at 18:45, >= wrote: -----Original Message----- From: dteske@FreeBSD.org [mailto:dteske@FreeBS= D.org] Sent: Monday, March 31, 2014 12:05 PM To: 'Hiroki Sato'; dteske@FreeBSD.org =20 Cc: jhellenthal@dataix.net ; lists@jnielsen= .net ; rc@FreeBSD.org =20 Subject: RE: network.subr _aliasN handling =20 -----Original Message----- From: Hiroki Sato [mailto:hrs@FreeBSD.org] Sent: Sunday, March 30, 2014 8:18 PM To: dteske@FreeBSD.org =20 Cc: jhellenthal@dataix.net ; lists@jnielsen= .net ; rc@FreeBSD.org =20 Subject: Re: network.subr _aliasN handling =20 > wrote in <04f701cf4c85$d1929680$74b7c380$@FreeBSD.org >: =20 dt> But that wouldn't have deterred me. 30+ days of silence is dt> equivalent to acceptance -- just that I had noticed that the patch dt> could be expanded to include mdconfig{,2} scripts. Was going to dt> wait a full day to see if anyone balked at the expansion to dt> include mdconfig{,2} and then move forward. =20 I like the direction in general, but there are two more comments: =20 Committed change: http://svnweb.freebsd.org/changeset/base/264243 =20 1. sort(1) cannot be used [snip] =20 Problem solved. Ended up beefing up the internal sort function (sort_lite()). Gave it some more options and regression tested it against several inputs and flags to always produce the same output as sort(1). 2. Please put the normalization part into a function and use it in get_if_var(), too. Adding another code for the same functionality makes maintenance difficult. Aforementioned enhancements to address that included in mentioned SVN r264243. --=20 Devin _____________ The information contained in this message is proprietary and/or confidentia= l. If you are not the intended recipient, please: (i) delete the message an= d all copies; (ii) do not disclose, distribute or use the message in any ma= nner; and (iii) notify the sender immediately. In addition, please be aware= that any message addressed to our domain is subject to archiving and revie= w by persons other than the intended recipient. Thank you. _____________ The information contained in this message is proprietary and/or confidentia= l. If you are not the intended recipient, please: (i) delete the message an= d all copies; (ii) do not disclose, distribute or use the message in any ma= nner; and (iii) notify the sender immediately. In addition, please be aware= that any message addressed to our domain is subject to archiving and revie= w by persons other than the intended recipient. Thank you.