Date: Sat, 14 Apr 2007 15:42:46 +0400 From: Stanislav Sedov <stas@FreeBSD.org> To: pav@FreeBSD.org Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/contrib/top top.X top.c top.h src/usr.bin/top machine.c Message-ID: <20070414154246.89ad2946.stas@FreeBSD.org> In-Reply-To: <1176546959.54822.14.camel@ikaros.oook.cz> References: <200704141016.l3EAGqIs023798@repoman.freebsd.org> <1176546388.54822.11.camel@ikaros.oook.cz> <1176546959.54822.14.camel@ikaros.oook.cz>
next in thread | previous in thread | raw e-mail | index | archive | help
--Signature=_Sat__14_Apr_2007_15_42_46_+0400_X4.=ndj+OLjS1zXT Content-Type: text/plain; charset=US-ASCII Content-Disposition: inline Content-Transfer-Encoding: 7bit On Sat, 14 Apr 2007 12:35:59 +0200 Pav Lucistnik <pav@FreeBSD.org> mentioned: > > Also, is the width cut-off technical problem, or is it fixable? > See http://people.freebsd.org/~pav/top.png for what I mean. > Well, they allocate a static buffer of 128 byte lenght, so the result doesn't fit into it. Also, there's buffer overrun, since sprintf is used, not snprintf. Probably we should allocate the buffer dynamically depending on the screen width, but that requires some interface redesign between machine-dependent and independent parts. Already working on it. Thanks for info! -- Stanislav Sedov ST4096-RIPE --Signature=_Sat__14_Apr_2007_15_42_46_+0400_X4.=ndj+OLjS1zXT Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.6 (FreeBSD) iD8DBQFGIL42K/VZk+smlYERAq+cAJ44lsGc8jg2jRln4sZYzeuZvO5L7ACePJTD eqoIkGvsHvwdZRtVPmoK5GA= =8MYB -----END PGP SIGNATURE----- --Signature=_Sat__14_Apr_2007_15_42_46_+0400_X4.=ndj+OLjS1zXT--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20070414154246.89ad2946.stas>