Date: Wed, 26 May 2010 20:30:10 GMT From: Anonymous <swell.k@gmail.com> To: freebsd-ports-bugs@FreeBSD.org Subject: Re: ports/146979: editors/emacs configuration ignores "-D WITHOUT_X11" Message-ID: <201005262030.o4QKUAse045408@freefall.freebsd.org>
next in thread | raw e-mail | index | archive | help
The following reply was made to PR ports/146979; it has been noted by GNATS.
From: Anonymous <swell.k@gmail.com>
To: wahjava@gmail.com (Ashish SHUKLA)
Cc: Paul Hoffman <phoffman@proper.com>, bug-followup@FreeBSD.org, Giorgos Keramidas <keramida@freebsd.org>
Subject: Re: ports/146979: editors/emacs configuration ignores "-D WITHOUT_X11"
Date: Thu, 27 May 2010 00:26:36 +0400
wahjava@gmail.com (Ashish SHUKLA) writes:
> Ashish SHUKLA writes:
>
> [...]
>
>>> # Solaris requires -lintl if you want strerror (which calls dgettext)
>>> # to return localized messages.
>>> AC_CHECK_LIB(intl, dgettext)
>
>>> --- a.diff begins here ---
>>> Index: editors/emacs/Makefile
>>> ===================================================================
>>> RCS file: /a/.cvsup/ports/editors/emacs/Makefile,v
>>> retrieving revision 1.95
>>> diff -u -p -r1.95 Makefile
>>> --- editors/emacs/Makefile 21 May 2010 19:51:04 -0000 1.95
>>> +++ editors/emacs/Makefile 26 May 2010 05:12:18 -0000
>>> @@ -28,8 +28,6 @@ GNU_CONFIGURE= yes
>>> USE_GMAKE= yes
>>> USE_BZIP2= yes
>
>>> -USE_GETTEXT= yes
>>> -
>>> MAN1= b2m.1 ctags.1 ebrowse.1 emacs.1 emacsclient.1 etags.1 \
>>> grep-changelog.1 rcs-checkin.1
>>> PLIST_SUB= EMACS_VER=${EMACS_VER} EMACS_ARCH=${CONFIGURE_TARGET}
>>> --- a.diff ends here ---
>
> I'm not using the patch as it is, since emacs links with libintl.so if it
> founds one, and its dependencies depend on libintl directly or indirectly. In
> case dependency is not registered, then wiping off gettext won't cause emacs
> to deinstall, and might cause emacs to stop working.
>
> #v+
> % readelf -d /usr/local/bin/emacs |fgrep intl
> 0x0000000000000001 (NEEDED) Shared library: [libintl.so.8]
> #v-
I think such dependencies should pull gettext themselves, not emacs.
If they do not have GETTEXT in their Makefile but require -lintl when
linking then they should be fixed. Can you list them?
Besides, some ports do not respect WITHOUT_NLS ifdef (e.g., gtk and
glib) and it's useless for emacs built WITHOUT_X11 and WITHOUT_DBUS.
>
> For the patch, check the PR ports/147087.
>
> Thanks
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201005262030.o4QKUAse045408>