From owner-freebsd-bugs@freebsd.org  Thu Dec  3 09:00:50 2015
Return-Path: <owner-freebsd-bugs@freebsd.org>
Delivered-To: freebsd-bugs@mailman.ysv.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 by mailman.ysv.freebsd.org (Postfix) with ESMTP id D08C4A3C745
 for <freebsd-bugs@mailman.ysv.freebsd.org>;
 Thu,  3 Dec 2015 09:00:50 +0000 (UTC)
 (envelope-from bugzilla-noreply@freebsd.org)
Received: from kenobi.freebsd.org (kenobi.freebsd.org
 [IPv6:2001:1900:2254:206a::16:76])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (Client did not present a certificate)
 by mx1.freebsd.org (Postfix) with ESMTPS id BD588106C
 for <freebsd-bugs@FreeBSD.org>; Thu,  3 Dec 2015 09:00:50 +0000 (UTC)
 (envelope-from bugzilla-noreply@freebsd.org)
Received: from bugs.freebsd.org ([127.0.1.118])
 by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id tB390o9s066689
 for <freebsd-bugs@FreeBSD.org>; Thu, 3 Dec 2015 09:00:50 GMT
 (envelope-from bugzilla-noreply@freebsd.org)
From: bugzilla-noreply@freebsd.org
To: freebsd-bugs@FreeBSD.org
Subject: [Bug 204943] usr/src/sbin/newfs_msdos/mkfs_msdos.c:586: memory leak ?
Date: Thu, 03 Dec 2015 09:00:51 +0000
X-Bugzilla-Reason: AssignedTo
X-Bugzilla-Type: changed
X-Bugzilla-Watch-Reason: None
X-Bugzilla-Product: Base System
X-Bugzilla-Component: misc
X-Bugzilla-Version: 11.0-CURRENT
X-Bugzilla-Keywords: patch
X-Bugzilla-Severity: Affects Some People
X-Bugzilla-Who: dcb314@hotmail.com
X-Bugzilla-Status: New
X-Bugzilla-Priority: ---
X-Bugzilla-Assigned-To: freebsd-bugs@FreeBSD.org
X-Bugzilla-Target-Milestone: ---
X-Bugzilla-Flags: 
X-Bugzilla-Changed-Fields: 
Message-ID: <bug-204943-8-qWIBWwPwaW@https.bugs.freebsd.org/bugzilla/>
In-Reply-To: <bug-204943-8@https.bugs.freebsd.org/bugzilla/>
References: <bug-204943-8@https.bugs.freebsd.org/bugzilla/>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/
Auto-Submitted: auto-generated
MIME-Version: 1.0
X-BeenThere: freebsd-bugs@freebsd.org
X-Mailman-Version: 2.1.20
Precedence: list
List-Id: Bug reports <freebsd-bugs.freebsd.org>
List-Unsubscribe: <https://lists.freebsd.org/mailman/options/freebsd-bugs>,
 <mailto:freebsd-bugs-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-bugs/>
List-Post: <mailto:freebsd-bugs@freebsd.org>
List-Help: <mailto:freebsd-bugs-request@freebsd.org?subject=help>
List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/freebsd-bugs>,
 <mailto:freebsd-bugs-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Thu, 03 Dec 2015 09:00:50 -0000

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=204943

--- Comment #4 from David Binderman <dcb314@hotmail.com> ---
>Although this fix is not wrong as such, fixing the memory leak in this >extremely rare error case does not make much sense if the happy path and error >cases that may actually happen still leak the memory.

True, but if there were leaks on the main path, I'd have reported
them before a leak on an error path.

More detail:

$ ~/cppcheck/trunk/cppcheck --enable=all usr/src/sbin/newfs_msdos/mkfs_msdos.c
Checking usr/src/sbin/newfs_msdos/mkfs_msdos.c...
[usr/src/sbin/newfs_msdos/mkfs_msdos.c:586]: (error) Memory leak: img
$ 

I see no evidence of any other memory leaks, or any other detectable problems,
in the source code file.

A patch for the leak has been produced, problem closed AFAIK.

-- 
You are receiving this mail because:
You are the assignee for the bug.