Date: Mon, 23 Jan 2012 06:09:37 -0500 From: Eitan Adler <eadler@freebsd.org> To: Hiroki Sato <hrs@freebsd.org> Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org Subject: Re: svn commit: r230354 - head/usr.sbin/makefs Message-ID: <CAF6rxgnuvvcyMTjcLSQGg9j8owSC7Vh=cEgtW3u7_OwZZDRZsw@mail.gmail.com> In-Reply-To: <20120123.132840.618925004528110765.hrs@allbsd.org> References: <201201200138.q0K1cSou016739@svn.freebsd.org> <20120120.123256.1432718473132856309.hrs@allbsd.org> <CAF6rxg=VWzUcDuk_oN_wepJPejg8JnGBKm5oLXB7Y8JCW52t3w@mail.gmail.com> <20120123.132840.618925004528110765.hrs@allbsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Sun, Jan 22, 2012 at 11:28 PM, Hiroki Sato <hrs@freebsd.org> wrote: > ea> bug fix which could be upstreamed that would be great. On the other > ea> hand I would like to continue with my goal of making the non-contrib > ea> world compilable with CC=3Dgcc46. > ea> > ea> Should I revert this commit? > > =C2=A0I don't think it is needed. =C2=A0The makefs utility is a special c= ase > =C2=A0because it will probably diverge from the upstream to support > =C2=A0FreeBSD-specific feature in the future (this is one of the reasons > =C2=A0why it is not in contrib/). =C2=A0It didn't happen so far, however. Understood. > =C2=A0By the way, does gcc46 no longer allow unused code? gcc46 enables -Wunused-but-set-variable enabled with -Wextra. One possible solution is to just disable the warning, but IMHO having random unused variables just makes code harder to understand. It also enables a few other stricter checks for C conformance. > Generally speaking, I think it is enough to clean up unused code only whe= n we > =C2=A0actually change the code. If these were style(9) or "best practice" cleanups - I'd agree. However this was prompted by my specific goal of making the userland code compile with gcc46. It would be nice to see FreeBSD as compiler agnostic as possible. --=20 Eitan Adler Source & Ports committer X11, Bugbusting teams
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAF6rxgnuvvcyMTjcLSQGg9j8owSC7Vh=cEgtW3u7_OwZZDRZsw>