From owner-svn-ports-all@FreeBSD.ORG Wed Dec 10 15:54:26 2014 Return-Path: Delivered-To: svn-ports-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 4DBAB98B; Wed, 10 Dec 2014 15:54:26 +0000 (UTC) Received: from prod2.absolight.net (mx3.absolight.net [IPv6:2a01:678:2:100::25]) (using TLSv1 with cipher DHE-RSA-CAMELLIA256-SHA (256/256 bits)) (Client CN "plouf.absolight.net", Issuer "CAcert Class 3 Root" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 0CABD645; Wed, 10 Dec 2014 15:54:26 +0000 (UTC) Received: from prod2.absolight.net (localhost [127.0.0.1]) by prod2.absolight.net (Postfix) with ESMTP id 508D3BDC1F; Wed, 10 Dec 2014 16:54:22 +0100 (CET) Received: from gw.in.absolight.net (gw-ecl.in.absolight.net [79.143.241.69]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client CN "gw.in.absolight.net", Issuer "CA Cert Signing Authority" (not verified)) by prod2.absolight.net (Postfix) with ESMTPSA id 29149BDC1D; Wed, 10 Dec 2014 16:54:22 +0100 (CET) Received: from ogg.in.absolight.net (ogg.in.absolight.net [79.143.241.239]) by gw.in.absolight.net (Postfix) with ESMTP id F123F60E8; Wed, 10 Dec 2014 16:54:20 +0100 (CET) Received: from localhost (localhost [127.0.0.1]) by ogg.in.absolight.net (Postfix) with ESMTP id DAB507964EAA; Wed, 10 Dec 2014 16:54:18 +0100 (CET) Date: Wed, 10 Dec 2014 16:54:18 +0100 From: Mathieu Arnold To: Alexey Dokuchaev Subject: Re: svn commit: r374466 - head/Mk Message-ID: <06A4A7BDAD61A31C6EE5D912@ogg.in.absolight.net> In-Reply-To: <20141210151952.GA16023@FreeBSD.org> References: <201412101510.sBAFAeLg034594@svn.freebsd.org> <20141210151952.GA16023@FreeBSD.org> X-Mailer: Mulberry/4.0.8 (Mac OS X) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Content-Disposition: inline Cc: svn-ports-head@freebsd.org, svn-ports-all@freebsd.org, ports-committers@freebsd.org X-BeenThere: svn-ports-all@freebsd.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: SVN commit messages for the ports tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 10 Dec 2014 15:54:26 -0000 +--On 10 d=C3=A9cembre 2014 15:19:52 +0000 Alexey Dokuchaev = wrote: | On Wed, Dec 10, 2014 at 03:10:40PM +0000, Mathieu Arnold wrote: |> New Revision: 374466 |> URL: https://svnweb.freebsd.org/changeset/ports/374466 |> QAT: https://qat.redports.org/buildarchive/r374466/ |>=20 |> Log: |> Patches go into PATCHDIR, not FILESDIR. |> =20 |> Pointy hat to: Everybody that looked at the code review, me included. |=20 | Not really; I recall there was an idea to get rid of PATCHDIR altogether, | it's more of a relic these days. FILESDIR works equally well and makes | more sense (i.e. there is "files" directory and no "patches"). Maybe, but then, someone has to remove all of PATCHDIR, because before this fix, the framework would look at the patches in PATCHDIR, and save them in FILESDIR. --=20 Mathieu Arnold