From owner-svn-src-head@freebsd.org Mon Jun 3 14:28:50 2019 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id DD7C815B2AA3; Mon, 3 Jun 2019 14:28:49 +0000 (UTC) (envelope-from yaneurabeya@gmail.com) Received: from mail-pf1-x42d.google.com (mail-pf1-x42d.google.com [IPv6:2607:f8b0:4864:20::42d]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 5981C83026; Mon, 3 Jun 2019 14:28:49 +0000 (UTC) (envelope-from yaneurabeya@gmail.com) Received: by mail-pf1-x42d.google.com with SMTP id u17so10723288pfn.7; Mon, 03 Jun 2019 07:28:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:subject:from:in-reply-to:date:cc :content-transfer-encoding:message-id:references:to; bh=UhkldZ3cBQqWEajdOftToOW1UnFewLPEE7V8hS1koE4=; b=UW86+YZ78mx8SasjxferzwMxr0KK0xf7n61gKaVUlMEF17SQkm68luIKXLUvQ+qdk8 rIZYQ49YvMM61T9akXL3emojeiqsqt7DxYBLCpqpldJRbvhQ/+gU5PedGQ/VgB7+Wi5f P7WU0F7oulQDRLseuLt7hly7qbzMt1ooPOOlh/GsG/yk9gKfpCJHY+OiiN5aTfHJekbi 2uZejkd9Hi/F6aJGd7s9c8WoRe6NV8DElbR87so8hiIMSoJkevPnlvz3lAj3lwGX5kGK 8JQOqr3A6L8zzBdYA54S1ONRq7abAaYbbPeEQZeMg8uCblcwErt6tMqewrpwbVWnlAh/ tK5w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:subject:from:in-reply-to:date:cc :content-transfer-encoding:message-id:references:to; bh=UhkldZ3cBQqWEajdOftToOW1UnFewLPEE7V8hS1koE4=; b=JXayemositk1tj6qLSBBBrqUWVcosL95gKOQL/pB6QRJD6IRD5jIJLuZcgTvao7/s9 +butOyREAv0MMI5iKNCScMu/yfaV55wmCeVC0VTBdYgNI4o7qABtvs6gVQ51MW5N1ugg 2ZIOrlaucCQzdWxNNduAp7e0mYnwea5DoYU5mA8IMWxDeegO0ikRQW67fw+4N37rMS2D MnAMcojCHy2B0oGodduqwotgbRqLOYg9/Ltx48RxElEhODd88yGYTfXvS3MdmUDxg09c SHZ9tr2BSuC4WkUl5uyaz3VtkCJodb0dBeJmzmqmSHFwHz8AH1J6GnkvqTNDO8ISxQoY 0iHg== X-Gm-Message-State: APjAAAV9jcmPxsG58RlKyrokcT+O6Qt/ROx79OJCvFjrSJU1Rl+JDawO oTv9ryvO8VHPsjyuZSK4+KVtEUj9qR4= X-Google-Smtp-Source: APXvYqz8wCA0HwK9zqcv4rUPBgD92UBt4ffUJNaAwvLbjKBR+BkQpVfSr9ez0CtjcoXcTG3zyqIVKw== X-Received: by 2002:aa7:9a92:: with SMTP id w18mr2304467pfi.167.1559572127897; Mon, 03 Jun 2019 07:28:47 -0700 (PDT) Received: from [192.168.20.22] (c-73-19-52-228.hsd1.wa.comcast.net. [73.19.52.228]) by smtp.gmail.com with ESMTPSA id ce3sm3945550pjb.11.2019.06.03.07.28.46 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 03 Jun 2019 07:28:46 -0700 (PDT) Content-Type: text/plain; charset=utf-8 Mime-Version: 1.0 (1.0) Subject: Re: svn commit: r348521 - in head: . etc sys/conf sys/modules usr.bin/login usr.sbin/services_mkdb From: Enji Cooper X-Mailer: iPhone Mail (16F156) In-Reply-To: <201906022338.x52NcJV9070782@repo.freebsd.org> Date: Mon, 3 Jun 2019 07:28:46 -0700 Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Content-Transfer-Encoding: quoted-printable Message-Id: <99965642-23AF-492C-9D3E-19AE069AB323@gmail.com> References: <201906022338.x52NcJV9070782@repo.freebsd.org> To: Maxim Sobolev X-Rspamd-Queue-Id: 5981C83026 X-Spamd-Bar: ------ Authentication-Results: mx1.freebsd.org X-Spamd-Result: default: False [-6.97 / 15.00]; NEURAL_HAM_MEDIUM(-1.00)[-1.000,0]; NEURAL_HAM_SHORT(-0.97)[-0.965,0]; REPLY(-4.00)[]; NEURAL_HAM_LONG(-1.00)[-1.000,0] X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 03 Jun 2019 14:28:50 -0000 Hi Maxim, > On Jun 2, 2019, at 16:38, Maxim Sobolev wrote: >=20 > Author: sobomax > Date: Sun Jun 2 23:38:19 2019 > New Revision: 348521 > URL: https://svnweb.freebsd.org/changeset/base/348521 >=20 > Log: > Fix several places where tool name has been hardcoded: >=20 > install -> ${INSTALL} > mtree -> ${MTREE_CMD} > services_mkdb -> ${SERVICES_MKDB_CMD} > cap_mkdb -> ${CAP_MKDB_CMD} > pwd_mkdb -> ${PWD_MKDB_CMD} > kldxref -> ${KLDXREF_CMD} >=20 > If you do custom FreeBSD builds you may want to override those > in some cases. >=20 > Sponsored by: Sippy Software, Inc. Please get review from Bryan, Simon, or Warner next time, per MAINTAINER= S, to avoid breakage in the future. There are some sand traps in our build i= nfrastructure. ... > Modified: head/Makefile.inc1 > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D > --- head/Makefile.inc1 Sun Jun 2 22:27:26 2019 (r348520) > +++ head/Makefile.inc1 Sun Jun 2 23:38:19 2019 (r348521) > @@ -887,8 +887,8 @@ MTREEFLAGS+=3D -W > INSTALLFLAGS+=3D -h sha256 > .endif > .if defined(DB_FROM_SRC) || defined(NO_ROOT) > -IMAKE_INSTALL=3D INSTALL=3D"install ${INSTALLFLAGS}" > -IMAKE_MTREE=3D MTREE_CMD=3D"mtree ${MTREEFLAGS}" > +IMAKE_INSTALL=3D INSTALL=3D"${INSTALL} ${INSTALLFLAGS}" > +IMAKE_MTREE=3D MTREE_CMD=3D"${MTREE_CMD} ${MTREEFLAGS}" > .endif Please back out this part of the change as it is unnecessary and adds a d= ependency on sys.mk=E2=80=99s definitions. $PATH should contain, i.e., be po= pulated, with these tools when running make installworld. This is part of th= e logic behind how $ITOOLS, etc, works. Thank you very much for your work and the rest of the change though! -Enji=