From owner-cvs-all@FreeBSD.ORG Thu Oct 6 19:13:39 2005 Return-Path: X-Original-To: cvs-all@FreeBSD.org Delivered-To: cvs-all@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 90B6116A42C; Thu, 6 Oct 2005 19:13:39 +0000 (GMT) (envelope-from nate@root.org) Received: from www.cryptography.com (li-22.members.linode.com [64.5.53.22]) by mx1.FreeBSD.org (Postfix) with ESMTP id EEA2643D46; Thu, 6 Oct 2005 19:13:38 +0000 (GMT) (envelope-from nate@root.org) Received: from [10.0.0.33] (adsl-67-119-74-222.dsl.sntc01.pacbell.net [67.119.74.222]) by www.cryptography.com (8.12.8/8.12.8) with ESMTP id j96JDaSA013621 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NOT); Thu, 6 Oct 2005 12:13:37 -0700 Message-ID: <43457759.8090002@root.org> Date: Thu, 06 Oct 2005 12:13:29 -0700 From: Nate Lawson User-Agent: Mozilla Thunderbird 1.0.6 (Windows/20050716) X-Accept-Language: en-us, en MIME-Version: 1.0 To: Pawel Jakub Dawidek References: <200510061110.j96BAApc034176@repoman.freebsd.org> <20051006132738.GG603@wombat.fafoe.narf.at> <20051006144454.GF23662@garage.freebsd.pl> <20051006154754.GH603@wombat.fafoe.narf.at> <434560A7.2010603@root.org> <20051006175832.GA26614@garage.freebsd.pl> In-Reply-To: <20051006175832.GA26614@garage.freebsd.pl> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: cvs-src@FreeBSD.org, Stefan Farfeleder , cvs-all@FreeBSD.org, src-committers@FreeBSD.org Subject: Re: cvs commit: src/sys/libkern strtok.c src/sys/sys libkern.h src/sys/conf files X-BeenThere: cvs-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the entire tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 06 Oct 2005 19:13:40 -0000 Pawel Jakub Dawidek wrote: > On Thu, Oct 06, 2005 at 10:36:39AM -0700, Nate Lawson wrote: > +> Stefan Farfeleder wrote: > +> >On Thu, Oct 06, 2005 at 04:44:54PM +0200, Pawel Jakub Dawidek wrote: > +> >>On Thu, Oct 06, 2005 at 03:27:40PM +0200, Stefan Farfeleder wrote: > +> >>+> On Thu, Oct 06, 2005 at 11:10:10AM +0000, Pawel Jakub Dawidek wrote: > +> >>+> > pjd 2005-10-06 11:10:10 UTC > +> >>+> > +> > FreeBSD src repository > +> >>+> > +> > Modified files: > +> >>+> > sys/sys libkern.h +> > sys/conf files +> > Added files: > +> >>+> > sys/libkern strtok.c +> > Log: > +> >>+> > Add strtok() and strtok_r() function to libkern. > +> >>+> +> Wouldn't it be better to have strsep() instead? > +> >>Actually we do have strsep() libkern already... > +> >Oops. Can you please change nfs_diskless.c to use strsep()? I think > +> >it's a mistake to add non-reentrant functions to libkern. > +> >Stefan > +> > +> Agreed. > > I wanted to use it to parse options for NFS root file system. > There is no race risk there, but I added also strtok_r() function. > > That was my thinking back then. I was wrong, I should look closer for > strsep() in libkern and just use it. Sorry for the mess I'll back it > out after some testing of setsep() version. Thanks. -- Nate