Skip site navigation (1)Skip section navigation (2)
Date:      Tue, 07 Oct 2014 19:36:54 -0500
From:      Bryan Drewery <bdrewery@FreeBSD.org>
To:        Matthias Andree <mandree@FreeBSD.org>, ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org
Subject:   Re: svn commit: r370411 - head/sysutils/e2fsprogs
Message-ID:  <54348726.1080004@FreeBSD.org>
In-Reply-To: <201410072343.s97Nhkgo093413@svn.freebsd.org>
References:  <201410072343.s97Nhkgo093413@svn.freebsd.org>

next in thread | previous in thread | raw e-mail | index | archive | help
This is an OpenPGP/MIME signed message (RFC 4880 and 3156)
--AAuoC2GxPpP8HsI9I4GjdgM75gkbiIgvQ
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable

On 10/7/2014 6:43 PM, Matthias Andree wrote:
> Author: mandree
> Date: Tue Oct  7 23:43:46 2014
> New Revision: 370411
> URL: https://svnweb.freebsd.org/changeset/ports/370411
> QAT: https://qat.redports.org/buildarchive/r370411/
>=20
> Log:
>   Mark broken everywhere, upstream bug (already reported).
>   To avoid PORTEPOCH/rollback-and-forth-again, let's give upstream a fe=
w
>   days for a fix before rolling back to 1.42.10.

This is horrible. We're providing no packages for any branch now to
avoid bumping a metadata counter?



>  =20
>   Added a comment to Makefile:
>  =20
>   # Regression that apparently causes use-after-free in=C2=B7
>   # http://git.kernel.org/cgit/fs/ext2/e2fsprogs.git/commit/?h=3Dmaint&=
id=3D47fee2ef6a23ae06f680336ffde57caa64604a4c
>   # and can be reproduced under MALLOC_OPTIONS=3DJ regime on 9.3-amd64,=
 or
>   # alternatively confirmed with valgrind, was reported upstream.
>   #
>   # Let's wait until 2014-10-15 whether upstream provides a fix,
>   # else we'll bump PORTEPOCH and roll back to 1.42.10;
>   # 1.42.11 is also faulty.
>=20
> Modified:
>   head/sysutils/e2fsprogs/Makefile
>=20
> Modified: head/sysutils/e2fsprogs/Makefile
> =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D
> --- head/sysutils/e2fsprogs/Makefile	Tue Oct  7 23:26:28 2014	(r370410)=

> +++ head/sysutils/e2fsprogs/Makefile	Tue Oct  7 23:43:46 2014	(r370411)=

> @@ -53,10 +53,6 @@ USES+=3D		gettext iconv:build
> =20
>  .include <bsd.port.pre.mk>
> =20
> -.if ${OSVERSION} >=3D 1100000
> -BROKEN=3D		Segfaults and miscalculations observed on redports
> -.endif
> -
>  .if ${PORT_OPTIONS:MNLS}
>  PLIST_SUB=3D	NLS=3D""
>  . if empty(ICONV_LIB)
> @@ -84,6 +80,16 @@ post-patch::
>  .endfor
> =20
>  .if ${MASTERDIR} =3D=3D ${.CURDIR}
> +# Regression that apparently causes use-after-free in=20
> +# http://git.kernel.org/cgit/fs/ext2/e2fsprogs.git/commit/?h=3Dmaint&i=
d=3D47fee2ef6a23ae06f680336ffde57caa64604a4c
> +# and can be reproduced under MALLOC_OPTIONS=3DJ regime on 9.3-amd64, =
or
> +# alternatively confirmed with valgrind, was reported upstream.
> +#
> +# Let's wait until 2014-10-15 whether upstream provides a fix,
> +# else we'll bump PORTEPOCH and roll back to 1.42.10;
> +# 1.42.11 is also faulty.
> +BROKEN=3D		Use-after-free bug, see ${.CURDIR}/Makefile comments for de=
tails
> +
>  pre-build:
>  # fix up Makefile ordering for parallel builds
>  	cd ${WRKSRC}/lib/et && ${DO_MAKE_BUILD} compile_et
>=20


--=20
Regards,
Bryan Drewery


--AAuoC2GxPpP8HsI9I4GjdgM75gkbiIgvQ
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: OpenPGP digital signature
Content-Disposition: attachment; filename="signature.asc"

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.10 (MingW32)

iQEcBAEBAgAGBQJUNIcnAAoJEDXXcbtuRpfPXrUIAIFCN4lYjlSns9lhY9FRqJlf
SX/O2nVG/BKoQKJZzRLIB3PF+V/8LRlb7AGaVCou9A3q8zEnRjfIcLQmxfNDlRbs
+IaByF++/sJKwYbqtBdheecm8gliTJBJdohbV+APL6DmAt9ODwNCOt4BFUWRV23u
HbvIvIuJ2AXQR+/8ByRlV2ZbVhSCGaVjPH7r9DrehRLkaglNoghBrkSBW2UOG71E
3pY/PBHDichK4CsEURoRqpZjt2hdBg9MdSCEOfGqZnhuRG8JgiisaV4Joge/S84Q
5g4Wfg2ed2I0SZdwSRW1zGMddvUaX6LpD15N+7LQZhw9v4KPDI0NvooO7ZZkkOE=
=VUMW
-----END PGP SIGNATURE-----

--AAuoC2GxPpP8HsI9I4GjdgM75gkbiIgvQ--



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?54348726.1080004>