Skip site navigation (1)Skip section navigation (2)
Date:      Sat, 29 Sep 2007 18:47:06 GMT
From:      Scot Hetzel <swhetzel@gmail.com>
To:        freebsd-gnats-submit@FreeBSD.org
Subject:   ports/116750: [patch] x11-toolkits/gtk20: fails to build when print/cups-base (1.3*) is installed
Message-ID:  <200709291847.l8TIl6ee019057@www.freebsd.org>
Resent-Message-ID: <200709291850.l8TIo1St007687@freefall.freebsd.org>

next in thread | raw e-mail | index | archive | help

>Number:         116750
>Category:       ports
>Synopsis:       [patch] x11-toolkits/gtk20: fails to build when print/cups-base (1.3*) is installed
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    freebsd-ports-bugs
>State:          open
>Quarter:        
>Keywords:       
>Date-Required:
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Sat Sep 29 18:50:01 GMT 2007
>Closed-Date:
>Last-Modified:
>Originator:     Scot Hetzel
>Release:        7.0-CURRENT
>Organization:
>Environment:
FreeBSD hp010.hetzel.org 7.0-CURRENT FreeBSD 7.0-CURRENT #0: Wed Sep 26 01:11:17 CDT 2007     root@hp010.hetzel.org:/usr/src/amd64/compile/GENERIC.debug  amd64

>Description:
Since the upgrade of print/cups-base to 1.3, gtk20 will no longer build when cups-base is installed.

Found fix at:

http://bugzilla.gnome.org/show_bug.cgi?id=467414
>How-To-Repeat:
install cups-base or define WITH_CUPS when building x11-toolkits/gtk20

cd /usr/ports/x11-toolkits/gtk20
make build
:
 cc -DHAVE_CONFIG_H -I. -I. -I../../.. -I../../.. -I../../../gtk -I../../../gtk -I../../../gdk -I../../../gdk -I/usr/local/include -DGTK_PRINT_BACKEND_ENABLE_UNSUPPORTED -D_REENTRANT -D_THREAD_SAFE -I/usr/local/include/glib-2.0 -I/usr/local/lib/glib-2.0/include -I/usr/local/include/pango-1.0 -I/usr/local/include/cairo -I/usr/local/include -I/usr/local/include/freetype2 -I/usr/local/include/atk-1.0 -DG_DISABLE_CAST_CHECKS -I/usr/local/include/freetype2 -I/usr/local/include -D_THREAD_SAFE -I/usr/local/include -DG_DISABLE_DEPRECATED -O2 -fno-strict-aliasing -pipe -march=k8 -Wall -MT gtkcupsutils.lo -MD -MP -MF .deps/gtkcupsutils.Tpo -c gtkcupsutils.c  -fPIC -DPIC -o .libs/gtkcupsutils.o
gtkcupsutils.c: In function '_post_send':
gtkcupsutils.c:631: error: dereferencing pointer to incomplete type
gtkcupsutils.c: In function '_get_send':
gtkcupsutils.c:970: error: dereferencing pointer to incomplete type
gmake[4]: *** [gtkcupsutils.lo] Error 1
gmake[4]: Leaving directory `/usr/ports/x11-toolkits/gtk20/work/gtk+-2.10.14/modules/printbackends/cups'
gmake[3]: *** [all-recursive] Error 1
gmake[3]: Leaving directory `/usr/ports/x11-toolkits/gtk20/work/gtk+-2.10.14/modules/printbackends'
gmake[2]: *** [all-recursive] Error 1
gmake[2]: Leaving directory `/usr/ports/x11-toolkits/gtk20/work/gtk+-2.10.14/modules'
gmake[1]: *** [all-recursive] Error 1
gmake[1]: Leaving directory `/usr/ports/x11-toolkits/gtk20/work/gtk+-2.10.14'
gmake: *** [all] Error 2
*** Error code 2

Stop in /usr/ports/x11-toolkits/gtk20.

>Fix:
add the attached file to the port.

NOTE: The attached patch will break the port for users of cups-base < 1.3 due to the use of httpGetAuthString.

Patch attached with submission follows:

--- modules/printbackends/cups/gtkcupsutils.c-orig	2007-09-29 13:01:34.226093342 -0500
+++ modules/printbackends/cups/gtkcupsutils.c	2007-09-29 13:04:59.458078750 -0500
@@ -628,7 +628,7 @@
   httpSetField(request->http, HTTP_FIELD_CONTENT_LENGTH, length);
   httpSetField(request->http, HTTP_FIELD_CONTENT_TYPE, "application/ipp");
 #ifdef HAVE_HTTP_AUTHSTRING
-  httpSetField(request->http, HTTP_FIELD_AUTHORIZATION, request->http->authstring);
+  httpSetField(request->http, HTTP_FIELD_AUTHORIZATION, httpGetAuthString (request->http));
 #endif
 
   if (httpPost(request->http, request->resource))
@@ -967,7 +967,7 @@
 
   httpClearFields(request->http);
 #ifdef HAVE_HTTP_AUTHSTRING
-  httpSetField(request->http, HTTP_FIELD_AUTHORIZATION, request->http->authstring);
+  httpSetField(request->http, HTTP_FIELD_AUTHORIZATION, httpGetAuthString (request->http));
 #endif
 
   if (httpGet(request->http, request->resource))


>Release-Note:
>Audit-Trail:
>Unformatted:



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200709291847.l8TIl6ee019057>