Skip site navigation (1)Skip section navigation (2)
Date:      Wed, 28 Jul 1999 17:55:58 -0700 (PDT)
From:      Matthew Dillon <dillon@apollo.backplane.com>
To:        "Brian F. Feldman" <green@FreeBSD.ORG>
Cc:        Nate Williams <nate@mt.sri.com>, hackers@FreeBSD.ORG, freebsd-ipfw@FreeBSD.ORG
Subject:   Re: securelevel and ipfw zero
Message-ID:  <199907290055.RAA65104@apollo.backplane.com>
References:   <Pine.BSF.4.10.9907281615560.92555-100000@janus.syracuse.net>

Next in thread | Previous in thread | Raw E-Mail | Index | Archive | Help
:On Wed, 28 Jul 1999, Nate Williams wrote:
:> > 
:> > These were changes that were necessary to make ipfw readable enough that
:> > I could work with it in this area. They aren't just to clean it up, or
:> > just for change's sake. They need to stay in.
:> 
:> C'mon now, re-ording the lines is *certainly* not necessary to work.
:
:That's true. I sure didn't do that.
:
:> 
:> *rant on*
:> Brian, FreeBSD isn't your private playground for playing around, this is
:> a group project, and you gotta follow the rules, or you don't get to
:> play with the rest of the folks....
:
:The rules don't say "leave the code that you work with in a bigger mess than
:when you started." Cleaning up code is a fact of life, and it _NEEDS_ to be
:done to get work done, very often. You have to learn to deal with that.
:
:> *rant off*
:> 
:> Nate
:> 
: Brian Fundakowski Feldman      _ __ ___ ____  ___ ___ ___  
: green@FreeBSD.org                   _ __ ___ | _ ) __|   \ 

    Side note:  I do the same thing:  clean up certain portions of the code
    in order to make them more readable while I'm working on the module.  And
    while I tend to agree that it would be nice to commit the bug fixes
    separately, it just isn't practical most of the time because one might
    have already spent too big a chunk of one's own time to do the work in 
    the first place.

    And I get the same sort of crap from certain core members, too.  It's 
    truely annoying when you've spent the time ( sometimes a whole LOT of
    time ) and trouble to fix something and all some people can do is 
    complain about extremely trivial elements of the work.

					-Matt
					Matthew Dillon 
					<dillon@backplane.com>


To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-ipfw" in the body of the message




Want to link to this message? Use this URL: <http://docs.FreeBSD.org/cgi/mid.cgi?199907290055.RAA65104>