Date: Fri, 4 Jun 1999 15:43:32 +0200 (MET DST) From: Nick Hibma <nick.hibma@jrc.it> To: Roger Hardiman <roger@cs.strath.ac.uk> Cc: Poul-Henning Kamp <phk@critter.freebsd.dk>, current@FreeBSD.ORG Subject: Re: cdevsw_add Message-ID: <Pine.GSO.3.95q.990604154157.15420j-100000@elect8> In-Reply-To: <3757D472.167E@cs.strath.ac.uk>
next in thread | previous in thread | raw e-mail | index | archive | help
> I've just fixed the bt848 driver (bktr) where the > cdevsw_add() was accidentally added to the BSDI bktr_probe() > and not the FreeBSD bktr_probe. > > Although Bruce and Nick said this really belongs, in the _attatch() > function, I've kept it in the _probe() function for consistency > with all the other drivers. Hm, I think this a bad choice. Which are 'all the other drivers'? The probe should really be as thin as possible to avoid unnecessary delays when probing in a kernel, like GENERIC, with a lot of device drivers compiled in. Nick -- ISIS/STA, T.P.270, Joint Research Centre, 21020 Ispra, Italy To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-current" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?Pine.GSO.3.95q.990604154157.15420j-100000>