Date: Tue, 03 Sep 2019 14:07:23 -0000 From: Enji Cooper <yaneurabeya@gmail.com> To: John Baldwin <jhb@FreeBSD.org> Cc: Enji Cooper <ngie@FreeBSD.org>, src-committers <src-committers@freebsd.org>, svn-src-projects@freebsd.org Subject: Re: svn commit: r346492 - projects/runtime-coverage-v2/lib/libclang_rt Message-ID: <C1C1A10D-727B-4CB9-9681-6955169F5E50@gmail.com> In-Reply-To: <e1229f59-ab16-b995-b645-afd1b89bf925@FreeBSD.org> References: <201904211926.x3LJQeg2024873@repo.freebsd.org> <e1229f59-ab16-b995-b645-afd1b89bf925@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
> On Apr 22, 2019, at 9:22 AM, John Baldwin <jhb@FreeBSD.org> wrote: >=20 > On 4/21/19 12:26 PM, Enji Cooper wrote: >> Author: ngie >> Date: Sun Apr 21 19:26:40 2019 >> New Revision: 346492 >> URL: https://svnweb.freebsd.org/changeset/base/346492 >>=20 >> Log: >> Build libclang_rt/profile on all clang-supported architectures >>=20 >> There's no reason why a special case needs to be added specifically = for amd64, >> arm, and i386, as the code is written in machine architecture = agnostic C/C++. >>=20 >> There might be compilation/link time issues, but we'll find out = soon. >=20 > For a sanitizer to be useful, you need to make sure clang's FreeBSD = driver > will actually use it. clang has builtin knowledge about which = sanitizers > work on which architectures. Just building the library alone doesn't = enable > it unless you also check the driver in clang. I haven't looked to see = what > conditions clang places on the profile case, but I am familiar with = this > from working on ASAN support for mips. Totally agree. What you=E2=80=99re referring to deals more with = ASAN/MSAN/TSAN, not profile, which is gcov-compatible profiling where = counters are incremented for lines hit and used in analysis tools like = coverity/lcov. gcov can be implemented in machine architecture = independent code. Cheers! -Enji=
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?C1C1A10D-727B-4CB9-9681-6955169F5E50>