From owner-freebsd-stable@FreeBSD.ORG Wed Feb 26 16:33:43 2014 Return-Path: Delivered-To: freebsd-stable@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 468F8542; Wed, 26 Feb 2014 16:33:43 +0000 (UTC) Received: from bigwig.baldwin.cx (bigwig.baldwin.cx [IPv6:2001:470:1f11:75::1]) (using TLSv1 with cipher ADH-CAMELLIA256-SHA (256/256 bits)) (No client certificate requested) by mx1.freebsd.org (Postfix) with ESMTPS id 1F79A1C30; Wed, 26 Feb 2014 16:33:43 +0000 (UTC) Received: from jhbbsd.localnet (unknown [209.249.190.124]) by bigwig.baldwin.cx (Postfix) with ESMTPSA id 1406CB995; Wed, 26 Feb 2014 11:33:42 -0500 (EST) From: John Baldwin To: freebsd-stable@freebsd.org Subject: Re: Fwd: panic after upgrade to 10 Date: Wed, 26 Feb 2014 11:24:01 -0500 User-Agent: KMail/1.13.5 (FreeBSD/8.4-CBSD-20130906; KDE/4.5.5; amd64; ; ) References: <5308B98C.6070807@semmy.ru> <5308BD0A.2050506@FreeBSD.org> In-Reply-To: <5308BD0A.2050506@FreeBSD.org> MIME-Version: 1.0 Content-Type: Text/Plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Message-Id: <201402261124.01275.jhb@freebsd.org> X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.2.7 (bigwig.baldwin.cx); Wed, 26 Feb 2014 11:33:42 -0500 (EST) Cc: Sergey Matveychuk X-BeenThere: freebsd-stable@freebsd.org X-Mailman-Version: 2.1.17 Precedence: list List-Id: Production branch of FreeBSD source code List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 26 Feb 2014 16:33:43 -0000 On Saturday, February 22, 2014 10:06:50 am Sergey Matveychuk wrote: > Hi. > > I've tried to upgrade my home router to FreeBSD 10-STABLE from 8.x. And > got this panic: https://www.dropbox.com/s/fxsily501x50vtw/A8eRRRJKbYM.jpg > > panic: make_dev_credv: bad si_name (error=17, si_name=agpgart) > > How it could be fixed or how work around to boot? I think the problem is there can only be one /dev/agpgart and this tried to create two. Odd that you would have two agp devices though. Try this patch which should fix the panic, but then capture a dmesg and 'pciconf -lcb' output. Index: sys/dev/agp.c =================================================================== --- agp.c (revision 262488) +++ agp.c (working copy) @@ -212,6 +212,7 @@ int agp_generic_attach(device_t dev) { struct agp_softc *sc = device_get_softc(dev); + struct cdev *cdev; int i; u_int memsize; @@ -256,10 +257,11 @@ agp_generic_attach(device_t dev) TAILQ_INIT(&sc->as_memory); sc->as_nextid = 1; - sc->as_devnode = make_dev(&agp_cdevsw, - 0, UID_ROOT, GID_WHEEL, 0600, "agpgart"); - sc->as_devnode->si_drv1 = dev; - + if (make_dev_p(MAKEDEV_CHECKNAME, &cdev, &agp_cdevsw, NULL, UID_ROOT, + GID_WHEEL, 0600, "agpgart") == 0) { + cdev->si_drv1 = dev; + sc->as_devnode = cdev; + } return 0; } @@ -268,7 +270,8 @@ agp_free_cdev(device_t dev) { struct agp_softc *sc = device_get_softc(dev); - destroy_dev(sc->as_devnode); + if (sc->as_devnode != NULL) + destroy_dev(sc->as_devnode); } void -- John Baldwin