Date: Fri, 26 Jan 2018 06:03:26 -0800 From: Cy Schubert <Cy.Schubert@cschubert.com> To: Conrad Meyer <cem@FreeBSD.org> Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r328417 - in head/sys: contrib/ipfilter/netinet fs/nfs fs/nfsclient fs/nfsserver netinet nfsclient sys Message-ID: <201801261403.w0QE3Qxf016584@slippy.cwsent.com> In-Reply-To: Message from Conrad Meyer <cem@FreeBSD.org> of "Thu, 25 Jan 2018 22:25:13 %2B0000." <201801252225.w0PMPDVQ023040@repo.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
In message <201801252225.w0PMPDVQ023040@repo.freebsd.org>, Conrad Meyer writes: > Author: cem > Date: Thu Jan 25 22:25:13 2018 > New Revision: 328417 > URL: https://svnweb.freebsd.org/changeset/base/328417 > > Log: > style: Remove remaining deprecated MALLOC/FREE macros > > Mechanically replace uses of MALLOC/FREE with appropriate invocations of > malloc(9) / free(9) (a series of sed expressions). Something like: > > * MALLOC(a, b, ... -> a = malloc(... > * FREE( -> free( > * free((caddr_t) -> free( > > No functional change. > > For now, punt on modifying contrib ipfilter code, leaving a definition of > the macro in its KMALLOC(). Yes, it's best not to deviate contrib code too much from original or we end up with a fork which is difficult to impossible to merge upstream into. Someone had suggested this very thing previously. Gleb (glebius) and I objected. > > Reported by: jhb > Reviewed by: cy, imp, markj, rmacklem > Sponsored by: Dell EMC Isilon > Differential Revision: https://reviews.freebsd.org/D14035 > > Modified: > head/sys/contrib/ipfilter/netinet/ip_compat.h > head/sys/fs/nfs/nfs_commonkrpc.c > head/sys/fs/nfs/nfs_commonsubs.c > head/sys/fs/nfs/nfsport.h > head/sys/fs/nfsclient/nfs_clcomsubs.c > head/sys/fs/nfsclient/nfs_clnode.c > head/sys/fs/nfsclient/nfs_clport.c > head/sys/fs/nfsclient/nfs_clrpcops.c > head/sys/fs/nfsclient/nfs_clstate.c > head/sys/fs/nfsclient/nfs_clsubs.c > head/sys/fs/nfsclient/nfs_clvfsops.c > head/sys/fs/nfsclient/nfs_clvnops.c > head/sys/fs/nfsclient/nfsnode.h > head/sys/fs/nfsserver/nfs_nfsdcache.c > head/sys/fs/nfsserver/nfs_nfsdport.c > head/sys/fs/nfsserver/nfs_nfsdserv.c > head/sys/fs/nfsserver/nfs_nfsdstate.c > head/sys/netinet/ip_mroute.c > head/sys/nfsclient/nfsnode.h > head/sys/sys/malloc.h > -- Cheers, Cy Schubert <Cy.Schubert@cschubert.com> FreeBSD UNIX: <cy@FreeBSD.org> Web: http://www.FreeBSD.org The need of the many outweighs the greed of the few.
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201801261403.w0QE3Qxf016584>